Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(visualizer): searchbar #1170

Merged
merged 13 commits into from
Feb 27, 2024
Merged

feat(visualizer): searchbar #1170

merged 13 commits into from
Feb 27, 2024

Conversation

panteleymonchuk
Copy link
Collaborator

Description of change

Closes #1126

Type of change

Feature.

How the change has been tested

You can do search now by latestFinalizedSlot or blockId

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes

@panteleymonchuk
feat: Add search state.
760a312 
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk
feat: poc highlight search results
88e275e 
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk
feat: highlight when add new block (not done)
993b732 
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk
feat: highlight when add new block
56d4533 
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk
fix: format
e56d6a5 
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk
refactor: clean code.
9aa1c32 
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk
Merge remote-tracking branch 'origin/dev' into feat/issues-1126-searc…
1a60b78 
…h-bar

Signed-off-by: Eugene Panteleymonchuk <[email protected]>

# Conflicts:
#	client/src/features/visualizer-threejs/VisualizerInstance.tsx
#	client/src/features/visualizer-threejs/store/tangle.ts
#	client/src/features/visualizer-threejs/wrapper/Wrapper.tsx
@panteleymonchuk
search by blockId
ad25b20 
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk panteleymonchuk linked an issue Feb 22, 2024 that may be closed by this pull request
[Task]: Fix searchbar in the visualizer so it behaves like the current vivagraph one #1126
Closed
@panteleymonchuk panteleymonchuk changed the title feat: searchbar feat(visualizer): searchbar Feb 22, 2024
VmMad
VmMad requested changes Feb 26, 2024
View reviewed changes
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions 👍

client/src/features/visualizer-threejs/hooks/useMouseMove.ts Outdated Show resolved Hide resolved
client/src/features/visualizer-threejs/hooks/useMouseMove.ts Outdated Show resolved Hide resolved
client/src/features/visualizer-threejs/hooks/useMouseMove.ts Outdated Show resolved Hide resolved
client/src/features/visualizer-threejs/hooks/useSearch.ts Outdated Show resolved Hide resolved
client/src/features/visualizer-threejs/constants.ts Outdated Show resolved Hide resolved
client/src/features/visualizer-threejs/wrapper/KeyPanel.tsx Outdated Show resolved Hide resolved
client/src/features/visualizer-threejs/wrapper/Wrapper.tsx Outdated Show resolved Hide resolved
VmMad
VmMad reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts

@panteleymonchuk
Merge branch 'dev' into feat/issues-1126-search-bar
fdf0fbd 
# Conflicts:
#	client/src/features/visualizer-threejs/VisualizerInstance.tsx
#	client/src/features/visualizer-threejs/constants.ts
@panteleymonchuk
Copy link
Collaborator Author

Conflicts

@VmMad branch updated

@begonaalvarezd begonaalvarezd merged commit 837c0be into dev Feb 27, 2024
4 of 6 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/issues-1126-search-bar branch February 27, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VmMad VmMad VmMad approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@msarcev msarcev Awaiting requested review from msarcev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Fix searchbar in the visualizer so it behaves like the current vivagraph one
3 participants
@panteleymonchuk @begonaalvarezd @VmMad