Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: handle multiple unlock types in getInputsPreExpandedConfig #1113

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Feb 13, 2024

Description of change

Fixes #1104

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

shimmer/transaction/0x02b8488d0cd5ff39d8ade27a73c11e85bbc46171e4479d60f194869d7ebdc7d1

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unlock references can be transitive, so we need to follow the path until we find the signature

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there seems to be a bug, if you visit the tx of the original issue /shimmer/transaction/0x02b8488d0cd5ff39d8ade27a73c11e85bbc46171e4479d60f194869d7ebdc7d1 there is a basic output that doesnt expand its address unlock
image

@VmMad VmMad requested a review from begonaalvarezd February 15, 2024 10:25
@VmMad
Copy link
Member Author

VmMad commented Feb 15, 2024

there seems to be a bug, if you visit the tx of the original issue /shimmer/transaction/0x02b8488d0cd5ff39d8ade27a73c11e85bbc46171e4479d60f194869d7ebdc7d1 there is a basic output that doesnt expand its address unlock image

Issue reference: #1121

@msarcev msarcev merged commit 507b49b into main Feb 16, 2024
5 checks passed
@msarcev msarcev deleted the feat/l1-l2-tx branch February 16, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Explorer crashes when viewing Token from L2
3 participants