Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mark finalized blocks #1096

Merged
merged 9 commits into from
Feb 16, 2024
Merged

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Feb 7, 2024

Description of change

Fixes #1036
Depends on iota-sdk/1962

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

  1. Change the finalized color to yellow #FFFF00
  2. Wait until there are ~400 blocks in the screen and pause the visualizer.
  3. Wait a moment until the blocks in the screen are marked as finalized

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@VmMad VmMad requested a review from msarcev February 7, 2024 18:01
@begonaalvarezd begonaalvarezd self-requested a review February 8, 2024 16:55
@VmMad VmMad marked this pull request as draft February 9, 2024 16:49
@VmMad VmMad marked this pull request as ready for review February 14, 2024 16:11
@VmMad VmMad requested a review from msarcev February 14, 2024 17:55
@VmMad VmMad requested a review from begonaalvarezd February 16, 2024 15:31
@begonaalvarezd begonaalvarezd merged commit 9131753 into dev Feb 16, 2024
3 of 5 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/nova/mark-finalized-blocks branch February 16, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Subscribe to commitment-info/finalized topic to mark finalized blocks
4 participants