Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update theme correctly and show dropdowns correctly #1043

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Jan 31, 2024

Description of change

Fixes #1042
Fixes #1041

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Theme change should work in the first attempt.
Dropdowns in mobile should be the same as in desktop

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@VmMad VmMad self-assigned this Jan 31, 2024
@msarcev msarcev merged commit 3ead1e2 into main Feb 1, 2024
5 checks passed
@msarcev msarcev deleted the fix/mobile-navbar branch February 1, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Dropdowns in mobile not working correctly [Task]: Theme change only working after second attempt
2 participants