Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expand relevant address in inputs and outputs inside the tx payload #1027

Merged
merged 14 commits into from
Jan 31, 2024

Conversation

begonaalvarezd
Copy link
Member

Description of change

Close #982

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • [] My code follows the contribution guidelines for this project
  • [] I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes

@begonaalvarezd begonaalvarezd marked this pull request as ready for review January 30, 2024 16:50
@begonaalvarezd begonaalvarezd changed the title [wip] feat: expand basic output spend and receive addresses feat: expand relevant address in inputs and outputs inside the tx payload Jan 30, 2024
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 👍
just small changes needed

client/src/app/components/stardust/Output.tsx Outdated Show resolved Hide resolved
client/src/app/components/stardust/interfaces/index.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊

@begonaalvarezd begonaalvarezd merged commit ac12b06 into main Jan 31, 2024
5 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/auto-expand-addresses branch January 31, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Automatically expand the relevant address in the tx summary
4 participants