Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Token amounts in milestone block page's referenced blocks #1018

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Fix: Token amounts in milestone block page's referenced blocks #1018

merged 1 commit into from
Jan 26, 2024

Conversation

brancoder
Copy link
Collaborator

Description of change

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

  • Navigate to milestone block with referenced transactions in the referenced blocks tab and than change pages

Change checklist

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

begonaalvarezd
begonaalvarezd approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 works

@begonaalvarezd begonaalvarezd merged commit 44fa7d8 into dev Jan 26, 2024
5 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/referenced-blocks-pagination branch January 26, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Wrong base token values in milestone block page's referenced blocks
2 participants
@brancoder @begonaalvarezd