fix: Allow InfluxService to be registered without 'initial ping' (#1468)

* fix: Allow InfluxService to be registered without 'initial ping' dependency (if it's configured we assume it works and register) * chore: bump version to v3.3.10-rc.2 --------- Co-authored-by: Begoña Álvarez de la Cruz <[email protected]>
iotaledger · May 8, 2024 · 0289727 · 0289727
1 parent 172d196
commit 0289727
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 29 deletions.
diff --git a/api/package-lock.json b/api/package-lock.json
diff --git a/api/package.json b/api/package.json
@@ -1,7 +1,7 @@
 {
     "name": "explorer-api",
     "description": "API for Tangle Explorer",
-    "version": "3.3.10-rc.1",
+    "version": "3.3.10-rc.2",
     "author": "Martyn Janes <[email protected]>",
     "repository": {
         "type": "git",

diff --git a/api/src/services/stardust/influx/influxDbClient.ts b/api/src/services/stardust/influx/influxDbClient.ts
@@ -1,4 +1,4 @@
-import { INanoDate, InfluxDB, IPingStats, IResults, toNanoDate } from "influx";
+import { INanoDate, InfluxDB, IResults, toNanoDate } from "influx";
 import moment from "moment";
 import cron from "node-cron";
 import {
@@ -134,7 +134,7 @@ export abstract class InfluxDbClient {
 
     /**
      * Build a new client instance asynchronously.
-     * @returns Boolean representing that the client ping succeeded.
+     * @returns Boolean representing that the client was initialised.
      */
     public async buildClient(): Promise<boolean> {
         const protocol = this._network.analyticsInfluxDbProtocol || "https";
@@ -157,27 +157,11 @@ export abstract class InfluxDbClient {
 
             const influxDbClient = new InfluxDB({ protocol, port, host, database, username, password, options });
 
-            return influxDbClient
-                .ping(1500)
-                .then((pingResults: IPingStats[]) => {
-                    if (pingResults.length > 0) {
-                        const anyHostIsOnline = pingResults.some((ping) => ping.online);
+            this._client = influxDbClient;
+            this.setupDataCollection();
+            logger.info(`[InfluxDb] Client started for "${network}"...`);
 
-                        if (anyHostIsOnline) {
-                            logger.info(`[InfluxDb] Client started for "${network}"...`);
-                            this._client = influxDbClient;
-                            this.setupDataCollection();
-                        }
-
-                        return anyHostIsOnline;
-                    }
-
-                    return false;
-                })
-                .catch((e) => {
-                    logger.verbose(`[InfluxDb] Ping failed for "${network}". ${e}`);
-                    return false;
-                });
+            return true;
         }
 
         logger.warn(`[InfluxDb] Configuration not found for "${network}".`);

diff --git a/client/package-lock.json b/client/package-lock.json
diff --git a/client/package.json b/client/package.json
@@ -1,7 +1,7 @@
 {
     "name": "explorer-client",
     "description": "Tangle Explorer UI",
-    "version": "3.3.10-rc.1",
+    "version": "3.3.10-rc.2",
     "author": "Martyn Janes <[email protected]>",
     "type": "module",
     "repository": {

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
     "name": "explorer",
     "description": "Tangle Explorer",
-    "version": "3.3.10-rc.1",
+    "version": "3.3.10-rc.2",
     "scripts": {
         "setup:client": "cd client && npm install && npm run postinstall",
         "setup:api": "cd api && npm install && npm run build-compile && npm run build-config",