Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor await methods #14

Merged
merged 9 commits into from
Nov 2, 2023
Merged

Refactor await methods #14

merged 9 commits into from
Nov 2, 2023

Conversation

jkrvivian
Copy link
Contributor

@jkrvivian jkrvivian commented Nov 1, 2023 •
edited
Loading

  • Move await methods from OutputManager to utils.go
  • Make use of await methods in codebase
  • Make utils a package to prevent circular dependency

Close #9

@jkrvivian jkrvivian requested a review from daria305 November 1, 2023 13:36
daria305
daria305 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@daria305 daria305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about switching from timeouts to number of retries, but it's ok for evil spammer needs. In accounts there is also retry func to wait for commitment, or other custom func that could take longer. We might later clean u also that

@jkrvivian jkrvivian merged commit bfe298f into main Nov 2, 2023
3 checks passed
@jkrvivian jkrvivian deleted the refactor-await branch November 2, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daria305 daria305 daria305 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Await... functions
2 participants
@jkrvivian @daria305