Test CI setup and cleanup old unused code #4
jkrviviangolangci-lint.yml
on: pull_request
GolangCI-Lint
3m 56s
Annotations
42 errors
|
[golangci] parse.go#L237:
parse.go#L237
Error return value is not checked (errcheck)
|
|
[golangci] parse.go#L240:
parse.go#L240
Error return value is not checked (errcheck)
|
|
[golangci] parse.go#L243:
parse.go#L243
Error return value is not checked (errcheck)
|
|
[golangci] parse.go#L246:
parse.go#L246
Error return value is not checked (errcheck)
|
|
[golangci] parse.go#L249:
parse.go#L249
Error return value is not checked (errcheck)
|
|
[golangci] parse.go#L252:
parse.go#L252
Error return value is not checked (errcheck)
|
|
[golangci] main.go#L33:
main.go#L33
string `basic` has 3 occurrences, make it a constant (goconst)
|
|
[golangci] config.go#L16:
config.go#L16
Comment should end in a period (godot)
|
|
[golangci] accountwallet/commands.go#L15:
accountwallet/commands.go#L15
`immediatelly` is a misspelling of `immediately` (misspell)
|
|
[golangci] accountwallet/wallet.go#L262:
accountwallet/wallet.go#L262
`commited` is a misspelling of `committed` (misspell)
|
|
[golangci] evilwallet/evilwallet.go#L157:
evilwallet/evilwallet.go#L157
`succesfully` is a misspelling of `successfully` (misspell)
|
|
[golangci] parse.go#L258:
parse.go#L258
`transfered` is a misspelling of `transferred` (misspell)
|
|
[golangci] parse.go#L285:
parse.go#L285
`Implict` is a misspelling of `Implicit` (misspell)
|
|
[golangci] accountwallet/commands.go#L70:
accountwallet/commands.go#L70
var-declaration: should drop = 0 from declaration of var rmc; it is the zero value (revive)
|
|
[golangci] accountwallet/commands.go#L55:
accountwallet/commands.go#L55
unused-parameter: parameter 'privateKey' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] accountwallet/commands.go#L82:
accountwallet/commands.go#L82
unused-parameter: parameter 'params' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] accountwallet/commands.go#L142:
accountwallet/commands.go#L142
unused-parameter: parameter 'params' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] evilwallet/evilwallet.go#L721:
evilwallet/evilwallet.go#L721
unused-parameter: parameter 'allotmentStrategy' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] interactive/interactive.go#L43:
interactive/interactive.go#L43
exported: type name will be used as interactive.InteractiveConfig by other packages, and that stutters; consider calling this Config (revive)
|
|
[golangci] accountwallet/commands.go#L97:
accountwallet/commands.go#L97
(*AccountWallet).createTransactionBuilder - result 1 (error) is always nil (unparam)
|
|
[golangci] accountwallet/faucet.go#L232:
accountwallet/faucet.go#L232
(*faucet).createFaucetTransactionNoManaHandling - result 2 (error) is always nil (unparam)
|
|
[golangci] accountwallet/wallet.go#L177:
accountwallet/wallet.go#L177
func `(*AccountWallet).registerAccount` is unused (unused)
|
|
[golangci] accountwallet/commands.go#L42:
accountwallet/commands.go#L42
type assertion must be checked (forcetypeassert)
|
|
[golangci] accountwallet/faucet.go#L155:
accountwallet/faucet.go#L155
type assertion must be checked (forcetypeassert)
|
|
[golangci] accountwallet/faucet.go#L221:
accountwallet/faucet.go#L221
type assertion must be checked (forcetypeassert)
|
|
[golangci] accountwallet/faucet.go#L240:
accountwallet/faucet.go#L240
type assertion must be checked (forcetypeassert)
|
|
[golangci] accountwallet/faucet.go#L263:
accountwallet/faucet.go#L263
type assertion must be checked (forcetypeassert)
|
|
[golangci] accountwallet/wallet.go#L317:
accountwallet/wallet.go#L317
type assertion must be checked (forcetypeassert)
|
|
[golangci] evilwallet/evilwallet.go#L290:
evilwallet/evilwallet.go#L290
type assertion must be checked (forcetypeassert)
|
|
[golangci] spammer/spammer.go#L258:
spammer/spammer.go#L258
type assertion must be checked (forcetypeassert)
|
|
[golangci] main.go#L82:
main.go#L82
type assertion must be checked (forcetypeassert)
|
|
[golangci] main.go#L92:
main.go#L92
type assertion must be checked (forcetypeassert)
|
|
[golangci] main.go#L108:
main.go#L108
type assertion must be checked (forcetypeassert)
|
|
[golangci] programs/spammers.go#L78:
programs/spammers.go#L78
loopclosure: loop variable i captured by func literal (govet)
|
|
[golangci] accountwallet/config.go#L61:
accountwallet/config.go#L61
return with no blank line before (nlreturn)
|
|
[golangci] accountwallet/wallet.go#L147:
accountwallet/wallet.go#L147
return with no blank line before (nlreturn)
|
|
[golangci] accountwallet/wallet.go#L340:
accountwallet/wallet.go#L340
return with no blank line before (nlreturn)
|
|
[golangci] evilwallet/evilwallet.go#L193:
evilwallet/evilwallet.go#L193
return with no blank line before (nlreturn)
|
|
[golangci] evilwallet/evilwallet.go#L431:
evilwallet/evilwallet.go#L431
return with no blank line before (nlreturn)
|
|
[golangci] evilwallet/evilwallet.go#L791:
evilwallet/evilwallet.go#L791
return with no blank line before (nlreturn)
|
|
[golangci] accountwallet/config.go#L69:
accountwallet/config.go#L69
json(camel): got 'accountID' want 'accountId' (tagliatelle)
|
|
GolangCI-Lint
reviewdog exited with status code: 1
|