-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ionoscloud: Update ionos-cloud-sdk-go and add metrics #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ticket mentions "Allow deploying in-cluster autoscaler in staging". Is that reflected in here somehow? If so, where?
cluster-autoscaler/cloudprovider/ionoscloud/mock_api_client_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/cloudprovider/ionoscloud/ionoscloud_manager_test.go
Outdated
Show resolved
Hide resolved
The PR description's metrics example looks outdated. |
Ah, seems I forgot to push my latest changes. |
The client is always constructed using config, which means that the endpoint is used even when IONOS_TOKEN is set. |
Add cloud API request metrics.
019c08c
to
f4d003d
Compare
cluster-autoscaler/cloudprovider/ionoscloud/ionoscloud_manager_test.go
Outdated
Show resolved
Hide resolved
LGTM |
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
Address a few things that built up over time:
Does this PR introduce a user-facing change?