Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ionoscloud: Update ionos-cloud-sdk-go and add metrics #4

Closed
wants to merge 6 commits into from

Conversation

avorima
Copy link
Collaborator

@avorima avorima commented Feb 29, 2024

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

Address a few things that built up over time:

  • Update ionos-cloud/sdk-go to v6.1.11
  • Fix example values link in provider README
  • Configurable additional request headers
  • Add cloud API response metrics
# HELP cluster_autoscaler_ionoscloud_api_request_total [ALPHA] Counter of IonosCloud API requests for each action and response status.
# TYPE cluster_autoscaler_ionoscloud_api_request_total counter
cluster_autoscaler_ionoscloud_api_request_total{action="DeleteNode",status="success"} 1
cluster_autoscaler_ionoscloud_api_request_total{action="GetNodePool",status="success"} 12
cluster_autoscaler_ionoscloud_api_request_total{action="ListNodes",status="success"} 10
cluster_autoscaler_ionoscloud_api_request_total{action="ResizeNodePool",status="success"} 1

Does this PR introduce a user-facing change?

Add `cluster_autoscaler_ionoscloud_api_request_total` alpha metric

@avorima avorima marked this pull request as draft February 29, 2024 20:38
Copy link

@piepmatz piepmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket mentions "Allow deploying in-cluster autoscaler in staging". Is that reflected in here somehow? If so, where?

@piepmatz
Copy link

The PR description's metrics example looks outdated.

@avorima
Copy link
Collaborator Author

avorima commented Mar 12, 2024

The PR description's metrics example looks outdated.

Ah, seems I forgot to push my latest changes.

@avorima
Copy link
Collaborator Author

avorima commented Mar 12, 2024

The ticket mentions "Allow deploying in-cluster autoscaler in staging". Is that reflected in here somehow? If so, where?

The client is always constructed using config, which means that the endpoint is used even when IONOS_TOKEN is set.

@piepmatz
Copy link

LGTM

@avorima avorima closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants