[READY] feat: add type parameters to class name

[deleonio]

TODO's

• Write test's
• Write doc (@see docs: add a component type parameter paragraph stencil-site#898)
• Tested with output target plugin

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build (npm run build) was run locally and any changes were pushed
• Unit tests (npm test) were run locally and passed
• E2E Tests (npm run test.karma.prod) were run locally and passed
• Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

GitHub Issue Number: #2895

What is the new behavior?

• We can use type parameters on component classes.

@Component({
       tag: 'kol-table',
        ...
})
export class KolTable<T> implements ... {
       ...
       @Prop() public _data!: T[];
       ...

Does this introduce a breaking change?

• Yes
• No

Testing

Other information

[deleonio]

Hello @rwaskiewicz,

the browserstack test failing with 30s timeout. Is that a code issue or a workload thing?

Thx

[rwaskiewicz]

@deleonio it appears they're running now...maybe a result of closing/opening the PR? 🤔

[deleonio]

Hi @rwaskiewicz,

browserstack was a little bit random - but now everything looks fine.

I set the PR to ready - I hope it is okay.

My next PRs:

• docs: add a component type parameter paragraph stencil-site#898
• Stencil-Output-Targets for TSX-template based Frameworks

[deleonio]

Output-Targets needs stencil release ...

• Angular: feat: add type parameter handling to angular output plugin stencil-ds-output-targets#279
• React: feat: add type parameter handling to react output plugin stencil-ds-output-targets#277
• Solid: Feat/add solid output target stencil-ds-output-targets#276
• Svelte:
• Vue: feat: add type parameter handling to vue output plugin stencil-ds-output-targets#278

[rwaskiewicz]

Thanks @deleonio! For a bigger feature like this, I'm going to label this for the team to discuss and review!

[deleonio]

Hello together,

this feature is very important for us and it would be nice if you take a look at it.

Thanks a lot

[rwaskiewicz]

Hey @deleonio,

This is currently in our backlog for the team to discuss. It's a interesting feature, but one that we'd like to take the time to discuss as a team. I don't have an ETA for you at this moment, and can't quite promise when we'll have the chance to take a look.

Thanks!

[deleonio]

Hello together,

what else is the reason that we haven't merged this feature yet?

What can we do to support you in this?

Please let's talk about how we can continue to improve Stencil and still stay efficient on the road.

That FEATURE ist really COOL. This allows us to flexibly type properties.

FYI: @mlynch, @bensperry, @nphyatt, @matthewkremer

Best regards

Martin

[deleonio]

Conflicts solved.

[jackdriscollukg]

Hey! I would also like to use this feature. Thanks for opening this PR and I hope it can get merged soon.

[deleonio]

Hi @jackdriscollukg, thanks for your support!

I see that you also focused on a11y - you should follow us on our community - https://github.com/public-ui/kolibri.

You are welcome!

[deleonio]

Hi @rwaskiewicz,

can you make a statement about this? Is the feature coming and if so, when?

[mhartington]

Hey @deleonio, the team has this in the backlog and will review when they can.

You do not need to ask for an update or tag various members of the ionic org 😄

[deleonio]

Hello @mhartington,

thank you very much for your reply!

I think it is possible to ask from time to time. We want to point out that maybe there is a feature that is not prioritized high enough. Also, the PR is not new, seems to be well integrated (x-resyncs with no conflicts) and you have unfortunately mostly not responded.

Basically, I have to conclude that this feature is not prioritized high enough and thus does not come into focus for editing.

The thing is, this feature vastly improves numerous typing situations while remaining simple. This is a great pity.

We've been thinking about forking Stencil for months now - but it's better to contribute to Stencil than to open special construction sites.

With kind regards
Martin

[jflynn7]

Any further update on getting this merged?

[deleonio]

Hi, in our team we are talking about this feature and we think it is interesting in general. Only for Angular with its proprietary template language it is unusable.

So, what can we do?