Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(react): instructions for next version of react-output-target #1412

Merged
merged 3 commits into from
Aug 23, 2024
Merged

docs(react): instructions for next version of react-output-target #1412

merged 3 commits into from
Aug 23, 2024

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Apr 25, 2024 •
edited
Loading

Updates the documentation for the React framework integration page for the changes from ionic-team/stencil-ds-output-targets#428.

  • Updates minimum React 17 requirement
  • Removes explicit typescript version, this is dependent on the version of Stencil
  • Updates to minimum Stencil v4.2.0 requirement
  • Updates the description and benefits list of using the framework wrappers
  • Adds file titles for code snippets
  • Removes dist FAQ and adds a new FAQ explaining the output target only supports dist-custom-elements
  • Updates API reference with the new public API
  • Adds installation instruction for runtime dependency for framework wrappers

Quick preview: https://stencil-docs-git-sp-react-output-target-ionic1.vercel.app/docs/next/react

@vercel Vercel
Copy link

vercel bot commented Apr 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stencil-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 6:35pm

@sean-perkins sean-perkins marked this pull request as ready for review August 23, 2024 18:33
@sean-perkins sean-perkins requested a review from a team as a code owner August 23, 2024 18:33
@sean-perkins sean-perkins requested review from christian-bromann and gnbm and removed request for a team August 23, 2024 18:33
@christian-bromann christian-bromann merged commit 57447d7 into main Aug 23, 2024
5 checks passed
@christian-bromann christian-bromann deleted the sp/react-output-target branch August 23, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

@gnbm gnbm Awaiting requested review from gnbm gnbm is a code owner automatically assigned from ionic-team/stencil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sean-perkins @christian-bromann