chore(readme): update release process #352
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
requested review from
JessicaSachs,
alicewriteswrongs and
mapsandapps
liamdebeasi
approved these changes
Jun 6, 2023
rwaskiewicz
reviewed
Jun 6, 2023
| You'll need to fill out a few bits of information when you submit the deploy workflow: | ||
| 1. Which package should be published (Currently `vue`, `react`, or `angular`). | ||
| 2. What version should be published. | ||
| 3. What npm tag it should be published under (`next` or `latest`) | ||
| 4. Any preid, like `alpha` or `rc` | ||
| 5. After the release has been published, you will need to manually bump the version in the `package.json` and `package-lock.json` files and commit the change. |
There was a problem hiding this comment.
Can you add a hint/example/suggestion to use npm version --no-git-tag-version to do this to ensure everything gets bumped properly?
| You'll need to fill out a few bits of information when you submit the deploy workflow: | ||
| 1. Which package should be published (Currently `vue`, `react`, or `angular`). | ||
| 2. What version should be published. | ||
| 3. What npm tag it should be published under (`next` or `latest`) | ||
| 4. Any preid, like `alpha` or `rc` | ||
| 5. After the release has been published, you will need to manually bump the version in the `package.json` and `package-lock.json` files and commit the change. |
There was a problem hiding this comment.
What do you think about having them create a tag as well? e.g. git tag -a @stencil/[email protected] -m "@stencil/vue-output-target v0.8.6" and have them push it to GH (git push origin @stencil/[email protected])?
sean-perkins
removed request for
JessicaSachs,
alicewriteswrongs and
mapsandapps
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally for affected output targetsnpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL:
What is the new behavior?
Does this introduce a breaking change?
Other information