chore: Add xcframework signing for Capacitor and Cordova

ionic-team · Apr 2, 2024 · a032d40 · a032d40
1 parent fe3c5b6
commit a032d40
Show file tree

Hide file tree

Showing 3 changed files with 97 additions and 86 deletions.
diff --git a/.github/workflows/pre-release.yml b/.github/workflows/pre-release.yml
@@ -20,6 +20,18 @@ jobs:
         run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/*/}" >> $GITHUB_ENV
       - name: Build Capacitor and Cordova
         run: ./build-cap $RELEASE_VERSION
+      - name: Sign Capacitor xcframework
+        uses: ionic-team/sign-xcframework@main
+        with:
+          cert-token: ${{ secrets.XCFRAMEWORK_SIGNING_TOKEN }}
+          xcframework-path: Capacitor.xcframework
+      - name: Sign Cordova xcframework
+        uses: ionic-team/sign-xcframework@main
+        with:
+          cert-token: ${{ secrets.XCFRAMEWORK_SIGNING_TOKEN }}
+          xcframework-path: Cordova.xcframework
+      - name: Package Capacitor and Cordova
+        run: ./package-cap $RELEASE_VERSION
       - name: Push manifest update
         uses: EndBug/add-and-commit@v9
       - name: Create Draft Release

diff --git a/build-cap b/build-cap
@@ -1,102 +1,53 @@
-#!/bin/bash -eoux pipefail
+#!/usr/bin/env bash -eoux pipefail
 
 build_capacitor_simulator() {
-  xcodebuild archive \
-    -scheme Capacitor \
-    -workspace Capacitor.xcworkspace \
-    -destination "generic/platform=iOS Simulator" \
-    -archivePath ./Build/iOS-Simulator \
-    -configuration Release \
-    SKIP_INSTALL=NO \
-    BUILD_LIBRARY_FOR_DISTRIBUTION=YES
+	xcodebuild archive \
+		-scheme Capacitor \
+		-workspace Capacitor.xcworkspace \
+		-destination "generic/platform=iOS Simulator" \
+		-archivePath ./Build/iOS-Simulator \
+		-configuration Release \
+		SKIP_INSTALL=NO \
+		BUILD_LIBRARY_FOR_DISTRIBUTION=YES
 }
 
 build_capacitor_ios() {
-  xcodebuild archive \
-    -scheme Capacitor \
-    -workspace Capacitor.xcworkspace \
-    -destination "generic/platform=iOS" \
-    -archivePath ./Build/iOS \
-    SKIP_INSTALL=NO \
-    SWIFT_SERIALIZE_DEBUGGING_OPTIONS=NO \
-    DEBUG_INFORMATION_FORMAT="dwarf-with-dsym" \
-    BUILD_LIBRARY_FOR_DISTRIBUTION=YES
+	xcodebuild archive \
+		-scheme Capacitor \
+		-workspace Capacitor.xcworkspace \
+		-destination "generic/platform=iOS" \
+		-archivePath ./Build/iOS \
+		SKIP_INSTALL=NO \
+		SWIFT_SERIALIZE_DEBUGGING_OPTIONS=NO \
+		DEBUG_INFORMATION_FORMAT="dwarf-with-dsym" \
+		BUILD_LIBRARY_FOR_DISTRIBUTION=YES
 }
 
 create_xcframeworks() {
-  build_capacitor_simulator
-  build_capacitor_ios
+	build_capacitor_simulator
+	build_capacitor_ios
+
+	rm -rf ./Build/iOS-Simulator.xcarchive/Products/Library/Frameworks/Capacitor.framework/Frameworks
+	rm -rf ./Build/iOS.xcarchive/Products/Library/Frameworks/Capacitor.framework/Frameworks
+
+	xcodebuild -create-xcframework \
+		-framework ./Build/iOS-Simulator.xcarchive/Products/Library/Frameworks/Capacitor.framework \
+		-debug-symbols $PWD/Build/iOS-Simulator.xcarchive/dSYMs/Capacitor.framework.dSYM \
+		-framework ./Build/iOS.xcarchive/Products/Library/Frameworks/Capacitor.framework \
+		-debug-symbols $PWD/Build/iOS.xcarchive/dSYMs/Capacitor.framework.dSYM \
+		-output Capacitor.xcframework
+
+	xcodebuild -create-xcframework \
+		-framework ./Build/iOS-Simulator.xcarchive/Products/Library/Frameworks/Cordova.framework \
+		-debug-symbols $PWD/Build/iOS-Simulator.xcarchive/dSYMs/Cordova.framework.dSYM \
+		-framework ./Build/iOS.xcarchive/Products/Library/Frameworks/Cordova.framework \
+		-debug-symbols $PWD/Build/iOS.xcarchive/dSYMs/Cordova.framework.dSYM \
+		-output Cordova.xcframework
 
-  rm -rf ./Build/iOS-Simulator.xcarchive/Products/Library/Frameworks/Capacitor.framework/Frameworks
-  rm -rf ./Build/iOS.xcarchive/Products/Library/Frameworks/Capacitor.framework/Frameworks
-
-  xcodebuild -create-xcframework \
-    -framework ./Build/iOS-Simulator.xcarchive/Products/Library/Frameworks/Capacitor.framework \
-    -debug-symbols $PWD/Build/iOS-Simulator.xcarchive/dSYMs/Capacitor.framework.dSYM \
-    -framework ./Build/iOS.xcarchive/Products/Library/Frameworks/Capacitor.framework \
-    -debug-symbols $PWD/Build/iOS.xcarchive/dSYMs/Capacitor.framework.dSYM \
-    -output Capacitor.xcframework
-
-  xcodebuild -create-xcframework \
-    -framework ./Build/iOS-Simulator.xcarchive/Products/Library/Frameworks/Cordova.framework \
-    -debug-symbols $PWD/Build/iOS-Simulator.xcarchive/dSYMs/Cordova.framework.dSYM \
-    -framework ./Build/iOS.xcarchive/Products/Library/Frameworks/Cordova.framework \
-    -debug-symbols $PWD/Build/iOS.xcarchive/dSYMs/Cordova.framework.dSYM \
-    -output Cordova.xcframework
-
-  zip -r Capacitor.xcframework.zip Capacitor.xcframework
-  zip -r Cordova.xcframework.zip Cordova.xcframework
-}
-
-write_package_file() {
-  cat << EOF > Package.swift
-// swift-tools-version:5.3
-
-import PackageDescription
-
-let package = Package(
-    name: "capacitor-swift-pm",
-    products: [
-        .library(
-            name: "Capacitor",
-            targets: ["Capacitor"]
-        ),
-        .library(
-            name: "Cordova",
-            targets: ["Cordova"]
-        )
-    ],
-    dependencies: [],
-    targets: [
-        .binaryTarget(
-            name: "Capacitor",
-            url: "$1",
-            checksum: "$2"
-        ),
-        .binaryTarget(
-            name: "Cordova",
-            url: "$3",
-            checksum: "$4"
-        )
-    ]
-)
-EOF
 }
 
 git clone https://github.com/ionic-team/capacitor capacitor-checkout
 cd capacitor-checkout/ios/Capacitor
 git checkout $1
 
 create_xcframeworks
-
-cap_url="https://github.com/ionic-team/capacitor-swift-pm/releases/download/$1/Capacitor.xcframework.zip"
-cap_sha=$(shasum -a 256 Capacitor.xcframework.zip | sed 's/ /\n/g' | head -n1 | xargs echo -n)
-cap_cordova_url="https://github.com/ionic-team/capacitor-swift-pm/releases/download/$1/Cordova.xcframework.zip"
-cap_cordova_sha=$(shasum -a 256 Cordova.xcframework.zip | sed 's/ /\n/g' | head -n1 | xargs echo -n)
-
-cd ../../../
-mkdir frameworks
-mv capacitor-checkout/ios/Capacitor/{Capacitor,Cordova}.xcframework.zip frameworks
-
-write_package_file $cap_url $cap_sha $cap_cordova_url $cap_cordova_sha
-
diff --git a/package-cap b/package-cap
@@ -0,0 +1,48 @@
+#!/usr/bin/env bash -eoux pipefail
+
+mkdir frameworks
+zip -r Capacitor.xcframework.zip capacitor-checkout/ios/Capacitor/Capacitor.xcframework
+zip -r Cordova.xcframework.zip capacitor-checkout/ios/Cordova.xcframework
+
+write_package_file() {
+  cat << EOF > Package.swift
+// swift-tools-version:5.3
+
+import PackageDescription
+
+let package = Package(
+    name: "capacitor-swift-pm",
+    products: [
+        .library(
+            name: "Capacitor",
+            targets: ["Capacitor"]
+        ),
+        .library(
+            name: "Cordova",
+            targets: ["Cordova"]
+        )
+    ],
+    dependencies: [],
+    targets: [
+        .binaryTarget(
+            name: "Capacitor",
+            url: "$1",
+            checksum: "$2"
+        ),
+        .binaryTarget(
+            name: "Cordova",
+            url: "$3",
+            checksum: "$4"
+        )
+    ]
+)
+EOF
+}
+
+cap_url="https://github.com/ionic-team/capacitor-swift-pm/releases/download/$1/Capacitor.xcframework.zip"
+cap_sha=$(shasum -a 256 Capacitor.xcframework.zip | sed 's/ /\n/g' | head -n1 | xargs echo -n)
+cap_cordova_url="https://github.com/ionic-team/capacitor-swift-pm/releases/download/$1/Cordova.xcframework.zip"
+cap_cordova_sha=$(shasum -a 256 Cordova.xcframework.zip | sed 's/ /\n/g' | head -n1 | xargs echo -n)
+
+write_package_file $cap_url $cap_sha $cap_cordova_url $cap_cordova_sha
+