Make Geolocation plugin work if Google Play Services are not enabled #2240
+129
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm currently in the process of packaging MapComplete into an Android app, with capacitor.
However, many of my users (including myselfs) are a bit paranoia and disable the Google Play Services or run custom ROMS without them. However, the geolocation plugin would refuse to work if those are not available.
As such, I have modified the geolocation-plugin to work with the google play services if they are available and to fallback to the stock Android API's if the Play Services are not available.
I've also moved some duplicated code into methods, in order to maintain some readability.