Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keyboard): Remove iOS keyboard delay (#1904) #2233

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Nov 6, 2024

  1. fix(keyboard): Remove iOS keyboard delay (ionic-team#1904)

    This fix aligns with the Android implementation of no delay.
    
    This fix removes all keyboard delay, including the 0.01 second
    delay for hiding. I believe this delay existed due to a slight
    flicker observed when setting delay to 0. However, by
    wrapping the height javascript logic in
    `requestAnimationFrame()` the flicker is no longer present.
    
    I believe this is a better solution than ionic-team#2230 because it
    avoids adding animations. (Users can do this themselves
    by disabling resizing and hooking into keyboardWillShow,
    didShow, willHide, and didHide events in javascript.)
    
    It also avoids magic/arbitrary delay amounts, like 0.01.
    aeharding committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    b38fce1 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Configuration menu
    Copy the full SHA
    59995f2 View commit details
    Browse the repository at this point in the history