Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(browser): browser close is now supported on android #2197

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bentleyo
Copy link

@bentleyo bentleyo commented Sep 19, 2024

Support for browser close on android was added here:
#1972

Also see: ionic-team/capacitor-docs#350

@bentleyo bentleyo changed the title Update readme as support for close on android was added in #1972 Update docs now that browser close is supported on android Sep 19, 2024
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as explained on ionic-team/capacitor-docs#350, this is generated from the definitions.ts file, so should be updated there and then generate the README.md with npm run build command

@bentleyo
Copy link
Author

@jcesarmobile thanks for explaining, my apologies about that. I've updated the PR 😄

@jcesarmobile jcesarmobile changed the title Update docs now that browser close is supported on android docs(browser): browser close is now supported on android Sep 20, 2024
@bentleyo

This comment was marked as off-topic.

@jcesarmobile
Copy link
Member

I have 0 Ionic experience, so no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants