-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable few more architectures #184
base: master
Are you sure you want to change the base?
Conversation
deprecated system calls are not available on several architectures
Debian already reports that this is building on s/390: https://buildd.debian.org/status/package.php?p=tlsdate&suite=jessie Is there a similar page for Fedora? I'm happy to merge in any case. |
Oh, S/390 lacks seccomp_filter in kernel so it builds without my patch. Similar with POWER. Heh, I wanted to be nice to them ;D I got info that POWER checks need to be changed a bit but that can be done on top of it (will provide patch). |
Fedora build infrastructure is split into primary architectures (x86, x86-64, arm) at http://koji.fedoraproject.org/ and secondary ones:
Looks like we run newer kernels on builders than Debian does as s/390 under Fedora has seccomp_filter support in kernel. |
Can you confirm that tlsdate works on these platforms with your patch and that it did not before your patch? Have you used it? |
No, was not even aware of it's existence. It failed to build on aarch64 so landed on my plate as "thing to fix". So I did. And then got asked "can you do POWER and S/390 while you are at this?" So I did. Can check tlsdate on all those platforms next week. |
s/390x: does not compile without patch, works after: [mjuszkie@devel6 tlsdate-tlsdate-0.0.13]$ ./A/bin/tlsdate -V Same on s/390 architecture. On both ppc64 and ppc64le it compiles and works without patch (but also with patch). |
Great - thank you!
Could you update your change set to update the changelog to reflect
all of your changes?
|
updated |
ping? |
I can confirm that two of these patches are necessary for a successful build on aarch64. |
ping? |
1 similar comment
ping? |
To get tlsdate built in Fedora we need support for all secondary architectures (AArch64, POWER, s/390).
Additionally had to mark open() system call as optional as it is deprecated one so does not exists on AArch64. openat() should be used instead.