Add rlimit and prevent the process from forking #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -183,6 +183,9 @@ AM_CONDITIONAL(HAVE_STRCHRNUL, [test "x${ac_cv_func_strchrnul}" = xyes]) | |||
| AC_CHECK_FUNCS([strnlen]) | |||
| AM_CONDITIONAL(HAVE_STRNLEN, [test "x${ac_cv_func_strnlen}" = xyes]) | |||
|
|
|||
| AC_CHECK_FUNCS([prlimit]) | |||
| AM_CONDITIONAL(HAVE_PRLIMIT, [test "x${ac_cv_func_prlmit}" = xyes]) | |||
There was a problem hiding this comment.
this AM_CONDITIONAL is pointless as it isn't used in the makefiles. just delete it.
There was a problem hiding this comment.
So I am not that fluent with automake/autoconf, but if I remove the AM_CONDITIONAL, is there value in keeping the AC_CHECK_FUNCS ?
There was a problem hiding this comment.
the AC_CHECK_FUNCS is needed to create HAVE_PRLIMIT which you use later on :)
While it doesn't prevent all exploitations, it make like harder for a attacker who would want to spawn a shell or similar type of attack.
mscherer
force-pushed
the
use_prlimit
branch
from
96f6cc1 to
b7376d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it doesn't prevent all exploitations, it make
like harder for a attacker who would want to spawn a shell
or similar type of attack.