-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix configure and build errors on OS X #160
base: master
Are you sure you want to change the base?
Conversation
Any thoughts? |
I'm wondering why |
06dae2c
to
36c0652
Compare
Yes, I think so too. I changed the PR! |
How does this impact other OS X builds? Could you please report on any other impacted platforms as well? |
On OS X 10.11.2 (15C50) |
your change is not equivalent -- it's changing the file offset when you use lseek. please change the code to use pread/pwrite instead. you should also split the commits up -- one to change the configure script and one to update the pread/pwrite logic |
Hi, sorry for the delay, I totally forgot about this PR. @vapier , you are right. I modified the patch to use pread and pwrite and split up the commit. @ioerror , I can only test ArchLinux, OS X 10.10 and OS X 10.11 but nothing older than that. |
…ure on OS X Signed-off-by: Clemens Gruber <[email protected]>
Fixes build errors on OS X and has better readability. Signed-off-by: Clemens Gruber <[email protected]>
36c0652
to
de4282e
Compare
Hi,
On OS X 10.10 I can only find
readv
andwritev
but notpreadv
orpwritev
, so I substitutedpreadv
withlseek
+readv
ifpreadv
is not available, and did the same forpwritev
.I also removed a seemingly redundant autoconf check for
clock_gettime
, which broke the OS X configuration. The same check already exists in the case statements for platforms, which needclock_gettime
.I tested my changes on OS X 10.10 (Yosemite) and Debian Wheezy (
make check
tests passed).I hope I did not break the build on any other platform.
If there is a better way to fix the build errors on OS X, please comment and I will update the PR.
Thanks.
Regards,
Clemens