forked from NHERI-SimCenter/pelicun
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs #4
Closed
Closed
Docs #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev update to 3.1.b5
scaling updates
azs - minor update to avoid saving logs by default
Add `dmg_process`, `block_batch_size`, and `scaling_specification` descriptions.
Introduces `ComponentLevelAssessment`, `SubAssemblyLevelAssessment`, and `PortfolioLevelAssessment` classes. Adds `calculate_damage`, `calculate_loss`, and `aggregate_loss` methods. Will be modified in future commits.
We initialize `out_files` as [] and then check if the existing files are in this empty list. They would never be members of the empty list, so the deletion code is uncreachable. This commit simply removes it. The expectation now is that existing files would be overwritten if the output filename already exists for some output, or left alone otherwise.
Rename `PAL` to `assessment`
Run pelicun no longer returns an int.
The idea behind this is to ensure the config is valid and contains whatever it should (this is the goal with this method), but its contents shouldn't be read into variables. Once the config is validated/modified/extended, the rest of the code can use it directly to get the needed information. Data retrieval from dictionaries is really fast and there is practically no penalty in doing it multiple times, so there is no need to extract data into variables.
To avoid the double-negative `if not is_unspecified(...)`
Use `config` directly.
It's just an empty list. No need for it to be instantiated in there.
`custom_dl_file_path = custom_model_dir`. No other change is made to it. Therefore we can just use `custom_model_dir` directly when needed.
Simplify functions by getting the demand sample directly from the demand model when needed instead of having it appear in function arguments and returned variables.
Adds `color_codes` argument in `log_msg`. If specified, it expects a tuple with `cpref`, `csuff`, the color codes obtained via `colorama` for RED. There is definitely room for improvement here, but this is a bit better than what we had before.
Moves config updating operations outside of `_loss` and into `_parse_config_file` where they belong.
Results in less indentation.
- The lines in the docstring for _handle_operation_list were too long - The keys of the parsed_scaling_specification dict do not need to be initialized
- Streamline part of the new test for capacity scaling
- Initialize the list in the nested dict when the scaling specs are parsed.
HAZUS bridge capacity scaling
- move updates from unreleased to v3.4 in release notes - update version number in init
minor fixes before release
Remove redundant material which is now available in the documentation.
- Eliminate redundant line breaks in notebook output. - Convert validation tests into examples, which can be refined later.
They result in warnings when the documentation is built.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test!