Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Matter for Beta Start #4504

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Add Matter for Beta Start #4504

merged 1 commit into from
Jan 26, 2025

Conversation

Apollon77
Copy link
Collaborator

Adds Matter Adapter, I will merge myself when we start the Beta

Adds Matter Adapter, I will merge myself when we start the Beta
@github-actions github-actions bot added auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review *📬 a new comment has been added labels Jan 25, 2025
@mcm1957
Copy link
Collaborator

mcm1957 commented Jan 25, 2025

OK to merge yourself of course :-)

@mcm1957 mcm1957 added REVIEW needed (apollon77) A developer from the ioBroker Team will review the adapter, will provide comments or require changes new at LATEST and removed *📬 a new comment has been added labels Jan 25, 2025
@github-actions github-actions bot added the *📬 a new comment has been added label Jan 25, 2025
@Apollon77
Copy link
Collaborator Author

Notes:

  • We decided against Compact mode for now because Matter is really "heavy" code and functionality wise and uses some central functionality on the Node.Js process and we do not know if really anything can be stopped on a shutdown in a way compact mode requires it. Matter also requires a bit more RAM, so the benefits running that inside compact is much lower than for other adapters
  • Exact dependency pinning is intentional for matter.js (to ensure 3 dependencies always have the same version), and for the others this will be changed as soon as current issues are solved there
  • Testing running special for Matter and also includes a test that the UI gets loaded and such and that's why it uses legacy-testing package intentionally
  • singletonHost is intentionally because of the heave usage of special Ports (MDNS and 5540+) where multiple instajces would collide.

@mcm1957
Copy link
Collaborator

mcm1957 commented Jan 25, 2025

All fine

  • Compact mode is already a suggestion only.
  • dependency pinning is notes as in most cases its not necessary and we had troubles at last js-controller update. But I will never consider it blocking.
  • testing is to be improved at checker, I'll note it. Please ignore for now
  • singleton* is primary as an aid for review. I'll search for a solution to "confirm" it. Please ignore for now.

@github-actions github-actions bot deleted a comment from Apollon77 Jan 26, 2025
Copy link

github-actions bot commented Jan 26, 2025

Automated adapter checker

ioBroker.matter

Downloads Number of Installations (latest) - Test and Release
NPM

  • ❗ [E035] No devDependency declared for @iobroker/testing. Please add "@iobroker/testing":"5.0.0" to devDependencies at package.json
  • 👀 [S139] Please evaluate whether adapter can be modified to support compact mode
  • 👀 [S526] Consider adding plugin "@alcalzone/release-script-plugin-manual-review".
  • 👀 [W047] dependency should not require a specific version. Use "~1.2.3" or "^1.2.3" syntax. Please update "@matter/main:0.12.1"
  • 👀 [W047] dependency should not require a specific version. Use "~1.2.3" or "^1.2.3" syntax. Please update "@matter/nodejs:0.12.1"
  • 👀 [W047] dependency should not require a specific version. Use "~1.2.3" or "^1.2.3" syntax. Please update "@project-chip/matter.js:0.12.1"
  • 👀 [W184] "common.singletonHost" detected for non onlyWWW adapter. Is this really desired?
  • 👀 [W401] Cannot find "matter" in latest repository

Add comment "RE-CHECK!" to start check anew

@mcm1957 mcm1957 removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review *📬 a new comment has been added labels Jan 26, 2025
@Apollon77 Apollon77 merged commit c506b58 into master Jan 26, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias new at LATEST REVIEW needed (apollon77) A developer from the ioBroker Team will review the adapter, will provide comments or require changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants