-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored adapter, Node-RED 3.1.x, added nodes, fixed issues #407
Conversation
klein0r
commented
Nov 17, 2023
•
edited
Loading
edited
- Add "sendTo" Node to send messages to adapters #291
- Attribute für ioBroker in #384
- [Question] How to switch back to ace editor? #332
- Defining Environment Variables for NodeRed Process #323
- regex Informative log message fills the log window #389
- Topics should be read when the dialogue is opened. #276
This reverts commit 5da552c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I added some comments
@klein0r Cool many thanks for this huge update! Just tell when you are done then I do a final look over it and we can release that (minor or major WDYT?) |
} | ||
return `${line.substring(0, pos)}${setValue}${line.substring(pos + toFind.length)}`; | ||
|
||
const cmd = `npm install ${npmLib} --omit=dev --prefix "${this.userDataDir}" --save`; |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input Medium
library input
shell command
// cert: require("fs").readFileSync('cert.pem') | ||
// } | ||
// }, | ||
'%%secure%%'https: { key: require("fs").readFileSync("'%%certPrivate%%'"), cert: require("fs").readFileSync("'%%certPublic%%'") }, |
Check notice
Code scanning / CodeQL
Syntax error Note
const oldText = fs.existsSync(settingsPath) ? fs.readFileSync(settingsPath, 'utf8') : ''; | ||
const newText = lines.join('\n'); | ||
if (oldText !== newText) { | ||
fs.writeFileSync(settingsPath, newText); |
Check failure
Code scanning / CodeQL
Potential file system race condition High
was checked
@Apollon77 I'm done so far. I will respond / check further issues if this is merged. Please release a major version, since I've changed a lot (e.g. admin config requires to re-enter all passwords). See added message in the io-package.json. |
@Apollon77 ping before dependabot creates merge conflicts by end of month 😄 |
5.0.0 on its way. Thank you very much! |