Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for other tax categories to myDATA addon #446

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

cavalle
Copy link
Contributor

@cavalle cavalle commented Dec 13, 2024

Describe your changes

This PR adds support for other tax categories to the myDATA addon.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents the show my changes in use, if appropriate.
  • When adding or modifying a tax regime or addon, I've added links to the source of the changes either structured or in the comments.
  • I've run go generate . to ensure that Schemas and Regime data are up to date.
  • All linter warnings have been reviewed and fixed.
  • I've been obsessive with pointer nil checks to avoid panics.
  • The CHANGELOG.md has been updated with an overview of my changes.
  • Requested a review from @samlown.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.90%. Comparing base (302269b) to head (d596396).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
+ Coverage   82.88%   82.90%   +0.02%     
==========================================
  Files         242      242              
  Lines       11875    11875              
==========================================
+ Hits         9842     9845       +3     
+ Misses       1672     1670       -2     
+ Partials      361      360       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cavalle cavalle marked this pull request as ready for review December 13, 2024 14:12
@cavalle cavalle requested a review from samlown December 13, 2024 14:12
@cavalle cavalle changed the title Gr other taxes Add support for other tax categories to myDATA addon Dec 13, 2024
Copy link
Collaborator

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like "other tax" for the name, it feels really confusing, but my "misc" suggestion is not much better. If you're happy with "other", we can go with that.

addons/gr/mydata/extensions.go Show resolved Hide resolved
@cavalle
Copy link
Contributor Author

cavalle commented Dec 16, 2024

I don't like "other tax" for the name, it feels really confusing, but my "misc" suggestion is not much better. If you're happy with "other", we can go with that.

I agree that, out of context, "other tax" feels confusing. However, in the context of myDATA, the "other tax" term is used consistently: in a couple of field names (otherTaxesPercentCategory and otherTaxesAmount), and in the official English version of the docs (screenshot below). For that reason, in the lack of a better alternative, I'd rather a name that directly maps to that naming.

@cavalle cavalle merged commit ab5152d into main Dec 16, 2024
7 checks passed
@cavalle cavalle deleted the gr-other-taxes branch December 16, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants