Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: moving to single cbc.Definition structure #441

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Conversation

samlown
Copy link
Collaborator

@samlown samlown commented Dec 5, 2024

Significant refactor moving from the cbc.KeyDefinition and cbc.ValueDefinition back to a single cbc.Definition that covers both key and code definitions.

Since the cbc.Code was recently made a lot more flexible, the use of "values" and tax.ExtValue no longer makes much sense.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents the show my changes in use, if appropriate.
  • When adding or modifying a tax regime or addon, I've added links to the source of the changes either structured or in the comments.
  • I've run go generate . to ensure that Schemas and Regime data are up to date.
  • All linter warnings have been reviewed and fixed.
  • I've been obsessive with pointer nil checks to avoid panics.
  • The CHANGELOG.md has been updated with an overview of my changes.
  • Requested a review from @samlown.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 98.51852% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.89%. Comparing base (eb70ac6) to head (98f196f).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
cbc/notes.go 0.00% 1 Missing ⚠️
tax/regime_def.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
+ Coverage   82.28%   82.89%   +0.61%     
==========================================
  Files         242      241       -1     
  Lines       11881    11892      +11     
==========================================
+ Hits         9776     9858      +82     
+ Misses       1737     1673      -64     
+ Partials      368      361       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samlown samlown requested a review from cavalle December 6, 2024 21:44
Base automatically changed from indian-tax-regime to main December 12, 2024 14:32
@samlown samlown merged commit c7664f4 into main Dec 12, 2024
4 checks passed
@samlown samlown deleted the cbc-definitions branch December 12, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant