Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always adding product extension to items, fix preceding validation #431

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

samlown
Copy link
Collaborator

@samlown samlown commented Nov 20, 2024

Changes

  • The es-tbai-product is now added automatically to all items during normalization.
  • TicketBAI validation was not correctly checking preceding data.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents the show my changes in use, if appropriate.
  • When adding or modifying a tax regime or addon, I've added links to the source of the changes either structured or in the comments.
  • I've run go generate . to ensure that Schemas and Regime data are up to date.
  • All linter warnings have been reviewed and fixed.
  • I've been obsessive with pointer nil checks to avoid panics.
  • The CHANGELOG.md has been updated with an overview of my changes.
  • Requested a review from @samlown.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.49%. Comparing base (78ccade) to head (77efc61).
Report is 36 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #431   +/-   ##
=======================================
  Coverage   81.48%   81.49%           
=======================================
  Files         233      233           
  Lines       11491    11417   -74     
=======================================
- Hits         9364     9304   -60     
+ Misses       1764     1752   -12     
+ Partials      363      361    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samlown samlown requested a review from cavalle November 20, 2024 12:08
Copy link
Contributor

@cavalle cavalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samlown samlown merged commit a97538b into main Nov 26, 2024
7 checks passed
@samlown samlown deleted the tbai-org-item-ext branch November 26, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants