Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting supplier validation #428

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Deleting supplier validation #428

merged 4 commits into from
Nov 19, 2024

Conversation

Menendez6
Copy link
Contributor

@Menendez6 Menendez6 commented Nov 18, 2024

Describe your changes

I just deleted the validation on Supplier in Swiss regime

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents the show my changes in use, if appropriate.
  • When adding or modifying a tax regime or addon, I've added links to the source of the changes either structured or in the comments.
  • I've run go generate . to ensure that Schemas and Regime data are up to date.
  • All linter warnings have been reviewed and fixed.
  • I've been obsessive with pointer nil checks to avoid panics.
  • The CHANGELOG.md has been updated with an overview of my changes.
  • Requested a review from @samlown.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.33%. Comparing base (99d792e) to head (1ac0530).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
- Coverage   81.34%   81.33%   -0.01%     
==========================================
  Files         231      230       -1     
  Lines       11369    11348      -21     
==========================================
- Hits         9248     9230      -18     
+ Misses       1760     1758       -2     
+ Partials      361      360       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Might be worth adding a test (or leaving the previous ones) to check that it is always possible to create invoices without a supplier tax ID.

@Menendez6 Menendez6 merged commit 3ac63ad into main Nov 19, 2024
7 checks passed
@Menendez6 Menendez6 deleted the swiss-u-2300 branch November 19, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants