Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty lines with discounts or charges, fix empty check #425

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

samlown
Copy link
Collaborator

@samlown samlown commented Nov 15, 2024

Describe your changes

Fixes #424. Invoices can now be built without lines if discounts or charges are present.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents the show my changes in use, if appropriate.
  • When adding or modifying a tax regime or addon, I've added links to the source of the changes either structured or in the comments.
  • I've run go generate . to ensure that Schemas and Regime data are up to date.
  • All linter warnings have been reviewed and fixed.
  • I've been obsessive with pointer nil checks to avoid panics.
  • The CHANGELOG.md has been updated with an overview of my changes.
  • Requested a review from @samlown.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.34%. Comparing base (930e513) to head (44f825c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
+ Coverage   81.18%   81.34%   +0.15%     
==========================================
  Files         231      231              
  Lines       11365    11369       +4     
==========================================
+ Hits         9227     9248      +21     
+ Misses       1777     1760      -17     
  Partials      361      361              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samlown samlown requested a review from cavalle November 15, 2024 14:43
@samlown samlown merged commit 2ab8dff into main Nov 15, 2024
7 checks passed
@samlown samlown deleted the fix-invoice-empty-lines branch November 15, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculate() panics when using addons on invoices with no lines
1 participant