Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing MX tax identity code validation with strange characters #407

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

samlown
Copy link
Collaborator

@samlown samlown commented Nov 1, 2024

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents the show my changes in use, if appropriate.
  • When adding or modifying a tax regime or addon, I've added links to the source of the changes either structured or in the comments.
  • I've run go generate . to ensure that Schemas and Regime data are up to date.
  • All linter warnings have been reviewed and fixed.
  • I've been obsessive with pointer nil checks to avoid panics.
  • The CHANGELOG.md has been updated with an overview of my changes.
  • Requested a review from @samlown.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.41%. Comparing base (2c2ffc4) to head (d8e9166).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   80.38%   80.41%   +0.03%     
==========================================
  Files         232      232              
  Lines       11297    11301       +4     
==========================================
+ Hits         9081     9088       +7     
+ Misses       1855     1853       -2     
+ Partials      361      360       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samlown samlown force-pushed the fix-tax-identity-code-validation branch from 7a5c395 to d8e9166 Compare November 4, 2024 12:01
@samlown samlown requested a review from cavalle November 4, 2024 12:11
@samlown samlown merged commit 98332e7 into main Nov 4, 2024
7 checks passed
@samlown samlown deleted the fix-tax-identity-code-validation branch November 4, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant