Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mx RFC symbol fix #404

Closed
wants to merge 27 commits into from
Closed

Mx RFC symbol fix #404

wants to merge 27 commits into from

Conversation

samlown
Copy link
Collaborator

@samlown samlown commented Oct 31, 2024

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents the show my changes in use, if appropriate.
  • When adding or modifying a tax regime or addon, I've added links to the source of the changes either structured or in the comments.
  • I've run go generate . to ensure that Schemas and Regime data are up to date.
  • All linter warnings have been reviewed and fixed.
  • I've been obsessive with pointer nil checks to avoid panics.
  • The CHANGELOG.md has been updated with an overview of my changes.
  • Requested a review from @samlown.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 91.25874% with 50 lines in your changes missing coverage. Please review.

Project coverage is 80.12%. Comparing base (834477c) to head (57ed5b5).
Report is 34 commits behind head on addon-de.

Files with missing lines Patch % Lines
addons/de/xrechnung/instructions.go 86.15% 6 Missing and 3 partials ⚠️
bill/charges.go 65.21% 7 Missing and 1 partial ⚠️
bill/discounts.go 68.18% 6 Missing and 1 partial ⚠️
org/inbox.go 87.87% 3 Missing and 1 partial ⚠️
addons/de/xrechnung/invoices.go 89.65% 2 Missing and 1 partial ⚠️
addons/eu/en16931/bill.go 93.02% 2 Missing and 1 partial ⚠️
regimes/mx/tax_identity.go 70.00% 2 Missing and 1 partial ⚠️
tax/regime_def.go 82.35% 2 Missing and 1 partial ⚠️
tax/tax.go 82.35% 2 Missing and 1 partial ⚠️
addons/eu/en16931/scenarios.go 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##           addon-de     #404      +/-   ##
============================================
+ Coverage     78.88%   80.12%   +1.24%     
============================================
  Files           217      229      +12     
  Lines         10722    11175     +453     
============================================
+ Hits           8458     8954     +496     
+ Misses         1909     1858      -51     
- Partials        355      363       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samlown samlown changed the base branch from main to addon-de October 31, 2024 12:32
@samlown samlown mentioned this pull request Oct 31, 2024
9 tasks
@samlown
Copy link
Collaborator Author

samlown commented Oct 31, 2024

Replaced with #405

@samlown samlown closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant