Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Brazil NFSe addon #402

Merged
merged 5 commits into from
Oct 29, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to GOBL will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/). See also the [GOBL versions](https://docs.gobl.org/overview/versions) documentation site for more details.

## [Unreleased]

### Added

- `br-nfse-v1`: added initial Brazil NFS-e addon

## [v0.203.0]

### Added
Expand Down
1 change: 1 addition & 0 deletions addons/addons.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ package addons

import (
// Import all the addons to ensure they're ready to use.
_ "github.com/invopop/gobl/addons/br/nfse"
_ "github.com/invopop/gobl/addons/co/dian"
_ "github.com/invopop/gobl/addons/es/facturae"
_ "github.com/invopop/gobl/addons/es/tbai"
Expand Down
32 changes: 32 additions & 0 deletions addons/br/nfse/extensions.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
package nfse

import (
"github.com/invopop/gobl/cbc"
"github.com/invopop/gobl/i18n"
"github.com/invopop/gobl/pkg/here"
)

// Brazilian extension keys required to issue NFS-e documents.
const (
ExtKeyService = "br-nfse-service"
)

var extensions = []*cbc.KeyDefinition{
{
Key: ExtKeyService,
Name: i18n.String{
i18n.EN: "Service Code",
i18n.PT: "Código Item Lista Serviço",
},
Desc: i18n.String{
i18n.EN: here.Doc(`
The service code as defined by the municipality. Typically, one of the codes listed
in the Lei Complementar 116/2003, but municipalities can make their own changes.

For further details on the list of possible codes, see:

* https://www.planalto.gov.br/ccivil_03/leis/lcp/lcp116.htm
`),
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is is possible to add a Pattern flag perhaps to validate the codes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose not to validate anything since every municipality can define their own list of codes without restrictions on the format. The list in LEI116 is commonly used, apparently, but there's no guarantee those will be the codes in the municipality.

},
}
21 changes: 21 additions & 0 deletions addons/br/nfse/item.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
package nfse

import (
"github.com/invopop/gobl/org"
"github.com/invopop/gobl/tax"
"github.com/invopop/validation"
)

func validateItem(value any) error {
item, _ := value.(*org.Item)
if item == nil {
return nil
}

Check warning on line 13 in addons/br/nfse/item.go

View check run for this annotation

Codecov / codecov/patch

addons/br/nfse/item.go#L12-L13

Added lines #L12 - L13 were not covered by tests

return validation.ValidateStruct(item,
validation.Field(&item.Ext,
tax.ExtensionsRequires(ExtKeyService),
validation.Skip,
),
)
}
62 changes: 62 additions & 0 deletions addons/br/nfse/item_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
package nfse_test

import (
"testing"

"github.com/invopop/gobl/addons/br/nfse"
"github.com/invopop/gobl/org"
"github.com/invopop/gobl/tax"
"github.com/stretchr/testify/assert"
)

func TestItemValidation(t *testing.T) {
tests := []struct {
name string
item *org.Item
err string
}{
{
name: "valid item",
item: &org.Item{
Ext: tax.Extensions{
nfse.ExtKeyService: "12345678",
},
},
},
{
name: "missing extensions",
item: &org.Item{},
err: "ext: (br-nfse-service: required.)",
},
{
name: "empty extensions",
item: &org.Item{
Ext: tax.Extensions{},
},
err: "ext: (br-nfse-service: required.)",
},
{
name: "missing extension",
item: &org.Item{
Ext: tax.Extensions{
"random": "12345678",
},
},
err: "ext: (br-nfse-service: required.).",
},
cavalle marked this conversation as resolved.
Show resolved Hide resolved
}

addon := tax.AddonForKey(nfse.V1)
for _, ts := range tests {
t.Run(ts.name, func(t *testing.T) {
err := addon.Validator(ts.item)
if ts.err == "" {
assert.NoError(t, err)
} else {
if assert.Error(t, err) {
assert.Contains(t, err.Error(), ts.err)
}
}
})
}
}
18 changes: 18 additions & 0 deletions addons/br/nfse/line.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package nfse

import (
"github.com/invopop/gobl/bill"
"github.com/invopop/gobl/regimes/br"
"github.com/invopop/validation"
)

func validateLine(value any) error {
line, _ := value.(*bill.Line)
if line == nil {
return nil
}

Check warning on line 13 in addons/br/nfse/line.go

View check run for this annotation

Codecov / codecov/patch

addons/br/nfse/line.go#L12-L13

Added lines #L12 - L13 were not covered by tests

return validation.Validate(line,
bill.RequireLineTaxCategory(br.TaxCategoryISS),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also need to be repeated for Discount and Charge and lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I don't think it makes sense to support either Charges or Discounts: it doesn't seem possible to map them to an NFSe. So, I've added validations to ensure those aren't present in 177eb69

)
}
67 changes: 67 additions & 0 deletions addons/br/nfse/line_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
package nfse_test

import (
"testing"

"github.com/invopop/gobl/addons/br/nfse"
"github.com/invopop/gobl/bill"
"github.com/invopop/gobl/regimes/br"
"github.com/invopop/gobl/tax"
"github.com/stretchr/testify/assert"
)

func TestLineValidation(t *testing.T) {
tests := []struct {
name string
line *bill.Line
err string
}{
{
name: "valid line",
line: &bill.Line{
Taxes: tax.Set{
{
Category: br.TaxCategoryISS,
},
},
},
},
{
name: "missing taxes",
line: &bill.Line{},
err: "taxes: missing category ISS.",
},
{
name: "empty taxes",
line: &bill.Line{
Taxes: tax.Set{},
},
err: "taxes: missing category ISS.",
},
{
name: "missing ISS tax",
line: &bill.Line{
Taxes: tax.Set{
{
Category: br.TaxCategoryPIS,
},
},
},
err: "taxes: missing category ISS.",
},
}

addon := tax.AddonForKey(nfse.V1)
for _, ts := range tests {
t.Run(ts.name, func(t *testing.T) {
err := addon.Validator(ts.line)
if ts.err == "" {
assert.NoError(t, err)
} else {
if assert.Error(t, err) {
assert.Contains(t, err.Error(), ts.err)
}
}
})
}
}
41 changes: 41 additions & 0 deletions addons/br/nfse/nfse.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
// Package nfse handles extensions and validation rules to issue NFS-e in
// Brazil.
package nfse

import (
"github.com/invopop/gobl/bill"
"github.com/invopop/gobl/cbc"
"github.com/invopop/gobl/i18n"
"github.com/invopop/gobl/org"
"github.com/invopop/gobl/tax"
)

const (
// V1 identifies the NFS-e addon version
V1 cbc.Key = "br-nfse-v1"
)

func init() {
tax.RegisterAddonDef(newAddon())
}

func newAddon() *tax.AddonDef {
return &tax.AddonDef{
Key: V1,
Name: i18n.String{
i18n.EN: "Brazil NFS-e 1.X",
},
Extensions: extensions,
Validator: validate,
}
}

func validate(doc any) error {
switch obj := doc.(type) {
case *bill.Line:
return validateLine(obj)
case *org.Item:
return validateItem(obj)
}
return nil

Check warning on line 40 in addons/br/nfse/nfse.go

View check run for this annotation

Codecov / codecov/patch

addons/br/nfse/nfse.go#L40

Added line #L40 was not covered by tests
}
21 changes: 21 additions & 0 deletions data/addons/br-nfse-v1.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"$schema": "https://gobl.org/draft-0/tax/addon-def",
"key": "br-nfse-v1",
"name": {
"en": "Brazil NFS-e 1.X"
},
"extensions": [
{
"key": "br-nfse-service",
"name": {
"en": "Service Code",
"pt": "Código Item Lista Serviço"
},
"desc": {
"en": "The service code as defined by the municipality. Typically, one of the codes listed\nin the Lei Complementar 116/2003, but municipalities can make their own changes.\n\nFor further details on the list of possible codes, see:\n\n* https://www.planalto.gov.br/ccivil_03/leis/lcp/lcp116.htm"
}
}
],
"scenarios": null,
"corrections": null
}
4 changes: 4 additions & 0 deletions data/schemas/bill/invoice.json
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,10 @@
"items": {
"$ref": "https://gobl.org/draft-0/cbc/key",
"oneOf": [
{
"const": "br-nfse-v1",
"title": "Brazil NFS-e 1.X"
},
{
"const": "co-dian-v2",
"title": "Colombia DIAN UBL 2.X"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ lines:
name: "Development services"
price: "90.00"
unit: "h"
ext:
br-nfse-service: "1.01"
discounts:
- percent: "10%"
reason: "Special discount"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"uuid": "8a51fd30-2a27-11ee-be56-0242ac120002",
"dig": {
"alg": "sha256",
"val": "5b7bb418d378de68d73da3f12f211648c5238e8ba916f4f5f00b2712f24d2476"
"val": "edfb9ac9ce7e8ceecb839cbfba109d8350ecf7408038e6eddd008cb294949456"
}
},
"doc": {
Expand Down Expand Up @@ -52,7 +52,10 @@
"item": {
"name": "Development services",
"price": "90.00",
"unit": "h"
"unit": "h",
"ext": {
"br-nfse-service": "1.01"
}
},
"sum": "1800.00",
"discounts": [
Expand Down
Loading