Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brazil regime #396

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Brazil regime #396

merged 4 commits into from
Oct 21, 2024

Conversation

cavalle
Copy link
Contributor

@cavalle cavalle commented Oct 18, 2024

No description provided.

@cavalle cavalle requested a review from samlown October 18, 2024 10:19
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 95.40230% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.81%. Comparing base (dc9192c) to head (ab05aa7).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
regimes/br/tax_identity.go 93.61% 2 Missing and 1 partial ⚠️
regimes/br/br.go 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
+ Coverage   78.68%   78.81%   +0.12%     
==========================================
  Files         214      217       +3     
  Lines       10632    10715      +83     
==========================================
+ Hits         8366     8445      +79     
- Misses       1911     1914       +3     
- Partials      355      356       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd strongly suggest removing the invoice validation file as it doesn't do anything and is unlikely to be needed. Thinking about how to do the addon in BR could be tougher (br-nfs-v1 maybe?)

Also, we want to avoid reducing test coverage ;-)

regimes/br/invoices.go Outdated Show resolved Hide resolved
@cavalle cavalle merged commit 65c59e5 into main Oct 21, 2024
7 checks passed
@cavalle cavalle deleted the br-regime branch October 21, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants