Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change and document payment method and means in MX #231

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

cavalle
Copy link
Contributor

@cavalle cavalle commented Jan 16, 2024

  • Documents how payment method (MethodPago) is inferred from the presence or absence of advances
  • Expects the payment means keys to be given in the advances (instead of in the instructions) when an invoice is prepaid to map to a FormaPago value.
  • Doesn't expect a payment means key in non-prepaid invoices. The FormaPago in that case must always be set 99 (Por definir)
  • Allows the payment means key to be given in the instructions temporarily until the users transition to use the advances

Copy link
Collaborator

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few possible copy suggestions. I like the approach with the advance key checks, makes sense. 👍

regimes/mx/README.md Outdated Show resolved Hide resolved
regimes/mx/README.md Outdated Show resolved Hide resolved
@cavalle
Copy link
Contributor Author

cavalle commented Jan 16, 2024

Thanks a lot @samlown! Copy suggestions are always very much appreciated!

@cavalle cavalle merged commit b599d5e into main Jan 16, 2024
2 checks passed
@samlown samlown deleted the mx-payment-means branch July 24, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants