New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain precision in category with taxes included #228

Merged

samlown merged 4 commits into main from tax-included-category-fix

Jan 8, 2024

Collaborator

samlown commented Dec 31, 2023

Fixes rounding issue calculating totals when prices include tax.


          Maintain precision in category with taxes included

09a6e15

samlown requested a review from cavalle

December 31, 2023 21:11

samlown added 3 commits

January 2, 2024 09:14


          Cleaning up some of the coments, removing RateTotal PreciseAmount


          Linter upgrade with fixes

4815d82


          Fixing comment and baseURL constant

984eb7d

cavalle approved these changes

View reviewed changes

Contributor

cavalle left a comment

Looks good to me! I'll rollback the 1 cent tolerance in the IX provider, when this is merged

samlown merged commit e491b8c into main

2 checks passed

samlown deleted the tax-included-category-fix branch

January 8, 2024 10:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet