Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validating all regimes, with scenario tag validation #225

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Validating all regimes, with scenario tag validation #225

merged 2 commits into from
Dec 5, 2023

Conversation

samlown
Copy link
Collaborator

@samlown samlown commented Dec 4, 2023

  • Fix that ensures all tax regimes are validated.
  • Adding common "partial" tag which was missing for Italian scenarios.

@samlown samlown requested a review from cavalle December 4, 2023 13:30
cavalle
cavalle approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@cavalle cavalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great idea to validate all tax regimes as part of the test suite

@samlown samlown merged commit bc24b6b into main Dec 5, 2023
2 checks passed
@samlown samlown deleted the valid-regimes branch December 5, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cavalle cavalle cavalle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samlown @cavalle