Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding it inbox key definitions #217

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Adding it inbox key definitions #217

merged 5 commits into from
Nov 20, 2023

Conversation

samlown
Copy link
Collaborator

@samlown samlown commented Nov 20, 2023

  • Support for inbox key definitions.
  • No consequences at the moment other than better aesthetics and attempt to standardise use of specific codes.

cavalle
cavalle approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@cavalle cavalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just left a couple of comments

data/regimes/it.json Outdated Show resolved Hide resolved
regimes/it/examples/hotel.json
@@ -39,7 +39,7 @@
"name": "Mela S.r.l.",
"inboxes": [
{
"key": "codice-destinatario",
"key": "it-sdi-code",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioning just in case: Is it safe to assume this won't break any existing implementation (e.g. Amenitiz) and that we don't need a migration?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, no one has used this in production, so I think we're good. Previous support was also a bit hacky without a specific constant to use. It'll be easy to add to the gobl.fatturapa tool though if anyone needs it.

@samlown @cavalle
Update data/regimes/it.json
4a14905 
Co-authored-by: Luismi Cavallé <[email protected]>
@samlown samlown merged commit 8787541 into main Nov 20, 2023
2 checks passed
@samlown samlown deleted the inbox-defs branch November 20, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cavalle cavalle cavalle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samlown @cavalle