Draft: PL regime #215
Merged
Draft: PL regime #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlown
reviewed
Dec 7, 2023
Comment on lines
+62
to
+73
| validation.Field(&obj.Name, | ||
| validation.When( | ||
| len(obj.People) == 0, | ||
| validation.Required, | ||
| ), | ||
| ), | ||
| validation.Field(&obj.People[0].Name, | ||
| validation.When( | ||
| obj.Name == "", | ||
| validation.Required, | ||
| ), | ||
| ), |
There was a problem hiding this comment.
This won't work as expected. Firstly and empty People array will cause a nil panic. An "org.Party" without a name will also not pass validation, so in effect the People array will never be checked.
I'm guessing the use-case here is for selling to individuals with tax details as opposed to companies. My proposal would be to just assume that the name is filled out, and optionally use the first "org.Person" from the people list, if available.
There was a problem hiding this comment.
I've merged this BTW with the https://github.com/invopop/gobl/tree/Risers-regime-pl branch, which you should now be able to access directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.