Centralising data in a single repository #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavalle
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Replicating my feedback on Slack: "having everything under the same roof is an improvement, but I agree the solution doesn't feel like a well-rounded one. I cannot help but think that, as convenient as it is, maybe these potentially large catalogs of data shouldn't be part of the GOBL binary…"
samlown
force-pushed
the
data-directory
branch
from
b468d8a to
7e1e29e
Compare
samlown
force-pushed
the
data-directory
branch
from
1bd7ff4 to
bbeec00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/data/regimespath./data/schemas.