adding missing Definition tests

invopop · Dec 5, 2024 · c9780d2 · c9780d2
1 parent 4d46676
commit c9780d2
Show file tree

Hide file tree

Showing 2 changed files with 106 additions and 11 deletions.
diff --git a/cbc/definition.go b/cbc/definition.go
@@ -97,7 +97,9 @@ func (d *Definition) KeyDef(key Key) *Definition {
 func DefinitionKeys(list []*Definition) []Key {
 	keys := make([]Key, 0, len(list))
 	for _, item := range list {
-		keys = append(keys, item.Key)
+		if item.Key != KeyEmpty {
+			keys = append(keys, item.Key)
+		}
 	}
 	return keys
 }
@@ -106,7 +108,9 @@ func DefinitionKeys(list []*Definition) []Key {
 func DefinitionCodes(list []*Definition) []Code {
 	codes := make([]Code, 0, len(list))
 	for _, item := range list {
-		codes = append(codes, item.Code)
+		if item.Code != CodeEmpty {
+			codes = append(codes, item.Code)
+		}
 	}
 	return codes
 }
@@ -146,7 +150,7 @@ func InKeyDefs(list []*Definition) validation.Rule {
 func InCodeDefs(list []*Definition) validation.Rule {
 	defs := make([]interface{}, len(list))
 	for i, item := range list {
-		defs[i] = item.Key
+		defs[i] = item.Code
 	}
 	return validation.In(defs...)
 }

diff --git a/cbc/definition_test.go b/cbc/definition_test.go
@@ -5,10 +5,34 @@ import (
 
 	"github.com/invopop/gobl/cbc"
 	"github.com/invopop/gobl/i18n"
+	"github.com/invopop/validation"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
+func TestDefinitionValidation(t *testing.T) {
+	t.Run("check pattern", func(t *testing.T) {
+		kd := &cbc.Definition{
+			Key: "key",
+			Name: i18n.String{
+				i18n.EN: "Name",
+				i18n.ES: "Nombre",
+			},
+			Pattern: "^[0-9]{3}$",
+		}
+		err := kd.Validate()
+		assert.NoError(t, err)
+
+		kd.Pattern = ""
+		err = kd.Validate()
+		assert.NoError(t, err)
+
+		kd.Pattern = "[foo]["
+		err = kd.Validate()
+		assert.ErrorContains(t, err, "pattern: error parsing regexp: missing closing ]: `[`")
+	})
+}
+
 func TestDefinitionsWithValues(t *testing.T) {
 	kd := &cbc.Definition{
 		Key: "key",
@@ -22,19 +46,86 @@ func TestDefinitionsWithValues(t *testing.T) {
 		},
 		Values: []*cbc.Definition{
 			{
-				Code: "value",
+				Code: "CODE1",
+				Name: i18n.String{
+					i18n.EN: "Code 1",
+					i18n.ES: "Código 1",
+				},
+			},
+			{
+				Code: "CODE2",
+				Name: i18n.String{
+					i18n.EN: "Code 2",
+					i18n.ES: "Código 2",
+				},
+			},
+			{
+				Key: "key1",
+				Name: i18n.String{
+					i18n.EN: "Key 1",
+					i18n.ES: "Clave 1",
+				},
+			},
+			{
+				Key: "key2",
 				Name: i18n.String{
-					i18n.EN: "Value",
-					i18n.ES: "Valor",
+					i18n.EN: "Key 2",
+					i18n.ES: "Clave 2",
 				},
 			},
 		},
 	}
-	assert.True(t, kd.HasCode("value"))
-	assert.False(t, kd.HasCode("invalid"))
-	vd := kd.CodeDef("value")
-	require.NotNil(t, vd)
-	assert.Equal(t, "Value", vd.Name[i18n.EN])
+	t.Run("for codes", func(t *testing.T) {
+		assert.True(t, kd.HasCode("CODE1"))
+		assert.False(t, kd.HasCode("INV"))
+		vd := kd.CodeDef("CODE1")
+		require.NotNil(t, vd)
+		assert.Equal(t, "Code 1", vd.Name[i18n.EN])
+
+		codes := cbc.DefinitionCodes(kd.Values)
+		assert.Len(t, codes, 2)
+		assert.Contains(t, codes, cbc.Code("CODE1"))
+		assert.Contains(t, codes, cbc.Code("CODE2"))
+
+		cdn := cbc.GetCodeDefinition("FOO", kd.Values)
+		assert.Nil(t, cdn)
+
+		cd := cbc.GetCodeDefinition("CODE2", kd.Values)
+		require.NotNil(t, cd)
+		assert.Equal(t, "Code 2", cd.Name[i18n.EN])
+
+		err := validation.Validate(cbc.Code("CODE1"), cbc.InCodeDefs(kd.Values))
+		assert.NoError(t, err)
+
+		err = validation.Validate(cbc.Code("INV"), cbc.InCodeDefs(kd.Values))
+		assert.ErrorContains(t, err, "must be a valid value")
+
+	})
+	t.Run("for keys", func(t *testing.T) {
+		assert.True(t, kd.HasKey("key1"))
+		assert.False(t, kd.HasKey("bad"))
+		vd := kd.KeyDef("key1")
+		require.NotNil(t, vd)
+		assert.Equal(t, "Key 1", vd.Name[i18n.EN])
+
+		keys := cbc.DefinitionKeys(kd.Values)
+		assert.Len(t, keys, 2)
+		assert.Contains(t, keys, cbc.Key("key1"))
+		assert.Contains(t, keys, cbc.Key("key2"))
+
+		kdn := cbc.GetKeyDefinition("bad", kd.Values)
+		assert.Nil(t, kdn)
+
+		kdn = cbc.GetKeyDefinition("key2", kd.Values)
+		require.NotNil(t, kdn)
+		assert.Equal(t, "Key 2", kdn.Name[i18n.EN])
+
+		err := validation.Validate(cbc.Key("key1"), cbc.InKeyDefs(kd.Values))
+		assert.NoError(t, err)
+
+		err = validation.Validate(cbc.Key("bad"), cbc.InCodeDefs(kd.Values))
+		assert.ErrorContains(t, err, "must be a valid value")
+	})
 }
 
 func TestDefinitionWithPattern(t *testing.T) {