Merge branch 'main' of github.com:invopop/gobl into hungary

.github/pull_request_template.md

@@ -9,5 +9,6 @@
 - [ ] I've run `go generate .` to ensure that Schemas and Regime data are up to date.
 - [ ] All linter warnings have been reviewed and fixed.
 - [ ] I've been obsessive with pointer nil checks to avoid panics.
+- [ ] The CHANGELOG.md has been updated with an overview of my changes.
 - [ ] Requested a review from @samlown.
 

CHANGELOG.md

@@ -4,17 +4,19 @@ All notable changes to GOBL will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/). See also the [GOBL versions](https://docs.gobl.org/overview/versions) documentation site for more details.
 
-## [Unreleased]
+## [v0.203.0]
 
 ### Added
 
 - `br`: added basic Brazil regime
-- `uuid` - SQL library compatibility for type conversion.
+- `uuid`: SQL library compatibility for type conversion.
+- `it-sdi-v1`: added `it-sdi-vat-liability` extension for EsigibilitaIVA.
 
 ### Fixed
 
-- `bill.Invoice` - remove empty taxes instances.
-- `tax.Identity` - support Calculate method to normalize IDs.
+- `bill.Invoice`: remove empty taxes instances.
+- `tax.Identity`: support Calculate method to normalize IDs.
+- `tax.Regime`: properly set regime when alternative codes is given.
 
 ## [v0.202.0]
 

addons/it/sdi/extensions.go

@@ -15,6 +15,7 @@ const (
 	ExtKeyExempt       cbc.Key = "it-sdi-exempt"
 	ExtKeyRetained     cbc.Key = "it-sdi-retained"
 	ExtKeyPaymentMeans cbc.Key = "it-sdi-payment-means"
+	ExtKeyVATLiability cbc.Key = "it-sdi-vat-liability"
 )
 
 var extensions = []*cbc.KeyDefinition{
@@ -29,7 +30,7 @@ var extensions = []*cbc.KeyDefinition{
 				Code used to describe the transmission format of the invoice. By default
 				the value "FPR12" is used unless the user explicitly sets the value
 				to something else.
-				
+
 				Normally this will only be needed when the invoice is to be sent to governmental
 				bodies and must use the "FPA12" format.
 			`),
@@ -458,7 +459,6 @@ var extensions = []*cbc.KeyDefinition{
 			},
 		},
 	},
-
 	{
 		// Retained reason code determined from the "CausalePagamento" field from FatturaPA.
 		// Source: https://www.agenziaentrate.gov.it/portale/documents/20143/4115385/CU_istr_2022.pdf
@@ -695,7 +695,6 @@ var extensions = []*cbc.KeyDefinition{
 			},
 		},
 	},
-
 	{
 		Key: ExtKeyPaymentMeans,
 		Name: i18n.String{
@@ -866,4 +865,34 @@ var extensions = []*cbc.KeyDefinition{
 			},
 		},
 	},
+	{
+		Key: ExtKeyVATLiability,
+		Name: i18n.String{
+			i18n.EN: "VAT Liability",
+			i18n.IT: "Esigibilità dell'IVA",
+		},
+		Values: []*cbc.ValueDefinition{
+			{
+				Value: "I",
+				Name: i18n.String{
+					i18n.EN: "Immediate",
+					i18n.IT: "Immediata",
+				},
+			},
+			{
+				Value: "D",
+				Name: i18n.String{
+					i18n.EN: "Deferred",
+					i18n.IT: "Differita",
+				},
+			},
+			{
+				Value: "S",
+				Name: i18n.String{
+					i18n.EN: "Split Payment",
+					i18n.IT: "Scissione dei pagamenti",
+				},
+			},
+		},
+	},
 }

data/addons/it-sdi-v1.json

@@ -890,6 +890,36 @@
           }
         }
       ]
+    },
+    {
+      "key": "it-sdi-vat-liability",
+      "name": {
+        "en": "VAT Liability",
+        "it": "Esigibilità dell'IVA"
+      },
+      "values": [
+        {
+          "value": "I",
+          "name": {
+            "en": "Immediate",
+            "it": "Immediata"
+          }
+        },
+        {
+          "value": "D",
+          "name": {
+            "en": "Deferred",
+            "it": "Differita"
+          }
+        },
+        {
+          "value": "S",
+          "name": {
+            "en": "Split Payment",
+            "it": "Scissione dei pagamenti"
+          }
+        }
+      ]
     }
   ],
   "tags": [

data/regimes/br.json

@@ -0,0 +1,135 @@
+{
+  "$schema": "https://gobl.org/draft-0/tax/regime-def",
+  "name": {
+    "en": "Brazil",
+    "pt": "Brasil"
+  },
+  "time_zone": "America/Sao_Paulo",
+  "country": "BR",
+  "currency": "BRL",
+  "tags": [
+    {
+      "schema": "bill/invoice",
+      "list": [
+        {
+          "key": "simplified",
+          "name": {
+            "de": "Vereinfachte Rechnung",
+            "en": "Simplified Invoice",
+            "es": "Factura Simplificada",
+            "it": "Fattura Semplificata"
+          },
+          "desc": {
+            "de": "Wird für B2C-Transaktionen verwendet, wenn die Kundendaten nicht verfügbar sind. Bitte wenden Sie sich an die örtlichen Behörden, um die Grenzwerte zu ermitteln.",
+            "en": "Used for B2C transactions when the client details are not available, check with local authorities for limits.",
+            "es": "Usado para transacciones B2C cuando los detalles del cliente no están disponibles, consulte con las autoridades locales para los límites.",
+            "it": "Utilizzato per le transazioni B2C quando i dettagli del cliente non sono disponibili, controllare con le autorità locali per i limiti."
+          }
+        },
+        {
+          "key": "reverse-charge",
+          "name": {
+            "de": "Umkehr der Steuerschuld",
+            "en": "Reverse Charge",
+            "es": "Inversión del Sujeto Pasivo",
+            "it": "Inversione del soggetto passivo"
+          }
+        },
+        {
+          "key": "self-billed",
+          "name": {
+            "de": "Rechnung durch den Leistungsempfänger",
+            "en": "Self-billed",
+            "es": "Facturación por el destinatario",
+            "it": "Autofattura"
+          }
+        },
+        {
+          "key": "customer-rates",
+          "name": {
+            "de": "Kundensätze",
+            "en": "Customer rates",
+            "es": "Tarifas aplicables al destinatario",
+            "it": "Aliquote applicabili al destinatario"
+          }
+        },
+        {
+          "key": "partial",
+          "name": {
+            "de": "Teilweise",
+            "en": "Partial",
+            "es": "Parcial",
+            "it": "Parziale"
+          }
+        }
+      ]
+    }
+  ],
+  "corrections": [
+    {
+      "schema": "bill/invoice",
+      "types": [
+        "credit-note"
+      ]
+    }
+  ],
+  "categories": [
+    {
+      "code": "ISS",
+      "name": {
+        "en": "ISS",
+        "pt": "ISS"
+      },
+      "title": {
+        "en": "Municipal Service Tax",
+        "pt": "Imposto Sobre Serviços"
+      }
+    },
+    {
+      "code": "ICMS",
+      "name": {
+        "en": "ICMS",
+        "pt": "ICMS"
+      },
+      "title": {
+        "en": "State value-added tax",
+        "pt": "Imposto sobre Circulação de Mercadorias e Serviços"
+      }
+    },
+    {
+      "code": "IPI",
+      "name": {
+        "en": "IPI",
+        "pt": "IPI"
+      },
+      "title": {
+        "en": "Federal value-added Tax",
+        "pt": "Imposto sobre Produtos Industrializados"
+      }
+    },
+    {
+      "code": "PIS",
+      "name": {
+        "en": "PIS",
+        "pt": "PIS"
+      },
+      "title": {
+        "en": "Social Integration Program",
+        "pt": "Programa de Integração Social"
+      },
+      "retained": true
+    },
+    {
+      "code": "COFINS",
+      "name": {
+        "en": "COFINS",
+        "pt": "COFINS"
+      },
+      "title": {
+        "en": "Contribution for the Financing of Social Security",
+        "pt": "Contribuição para o Financiamento da Seguridade Social"
+      },
+      "retained": true
+    }
+  ]
+}

data/schemas/bill/invoice.json

@@ -181,6 +181,10 @@
               "const": "BE",
               "title": "Belgium"
             },
+            {
+              "const": "BR",
+              "title": "Brazil"
+            },
             {
               "const": "CA",
               "title": "Canada"

tax/regime.go

@@ -26,11 +26,12 @@ func (r Regime) GetRegime() l10n.TaxCountryCode {
 // that the regime is actually defined. Missing regimes will silently replace
 // the current regime with an empty value.
 func (r *Regime) SetRegime(country l10n.TaxCountryCode) {
-	if Regimes().For(country.Code()) == nil {
+	rd := Regimes().For(country.Code())
+	if rd == nil {
 		r.Country = ""
 		return
 	}
-	r.Country = country
+	r.Country = rd.Country
 }
 
 // RegimeDef provides the associated regime definition.

tax/regimes_test.go

@@ -3,6 +3,7 @@ package tax_test
 import (
 	"testing"
 
+	"github.com/invopop/gobl/l10n"
 	"github.com/invopop/gobl/tax"
 	"github.com/stretchr/testify/assert"
 )
@@ -19,3 +20,22 @@ func TestRegimesAltCountryCodes(t *testing.T) {
 	r := tax.RegimeDefFor("GR")
 	assert.Equal(t, "EL", r.Country.String())
 }
+
+func TestSetRegime(t *testing.T) {
+	tests := []struct {
+		reg string
+		exp string
+	}{
+		{"ES", "ES"},
+		{"GR", "EL"},
+		{"YY", ""},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.reg, func(t *testing.T) {
+			r := new(tax.Regime)
+			r.SetRegime(l10n.TaxCountryCode(tt.reg))
+			assert.Equal(t, tt.exp, r.GetRegime().String())
+		})
+	}
+}

version.go

@@ -8,7 +8,7 @@ import (
 type Version string
 
 // VERSION is the current version of the GOBL library.
-const VERSION Version = "v0.202.0"
+const VERSION Version = "v0.203.0"
 
 // Semver parses and returns semver
 func (v Version) Semver() *semver.Version {