Introduction to SdI #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want the linter and tests to be true before making any changes.
Certificates available for "Interoperability Tests".
Types defined from XSD files.
torrocus
commented
May 13, 2024
| err := filepath.Walk(GetDataPath(), func(path string, info os.FileInfo, err error) error { | ||
| err := filepath.Walk(GetDataPath(), func(path string, _ os.FileInfo, _ error) error { |
There was a problem hiding this comment.
The code on the main branch didn't pass go-lint, so I had to use _.
torrocus
force-pushed
the
al-introduction-to-sdi
branch
from
76cb2b4 to
701122f
Compare
samlown
approved these changes
May 14, 2024
noplisu
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR introduces commits regarding SdI (Sistema di Interscambio). I added documentation, certificates, schemas (XSD, WSDL), structures (types) and basic helpers (support functions).
Feedback
These are basic changes. They don't break anything in the current package. We can safely merge them or I can add further changes to this PR.
(Opinion) I think it is better to merge it and introduce next changes in separate PRs. I still have some code in other files (separate repo), and I don't want this PR to get too big.
I think I managed to simplify a bit the SdI structures (types) that were more extensive in the original version.