Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extension validation #8

Merged
merged 6 commits into from
Dec 13, 2024
Merged

Add extension validation #8

merged 6 commits into from
Dec 13, 2024

Conversation

apardods
Copy link
Contributor

@apardods apardods commented Dec 4, 2024

No description provided.

@apardods apardods requested a review from samlown December 4, 2024 11:03
samlown
samlown approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the verifactu release of GOBL we'll have support for the Get method in extensions, which is much easier to use and avoids the risk of panics.

internal/gtoc/charges.go Outdated Show resolved Hide resolved
@apardods apardods merged commit d420d67 into main Dec 13, 2024
4 checks passed
@apardods apardods deleted the extensions-fix branch December 13, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlown samlown samlown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apardods @samlown