Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Due Dates added to XRechnung #7

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

MarlinKuhn
Copy link

Hi,

i've noticed, that you are able to parse the due dates from the finished cii but not the other way around.

A list of things i added/fixed:

  • included due dates into the settlement
  • added the partial payment amount to the due dates
  • fixed LineTotalAmount to not include charges and discounts
  • fixed CalculationPercent in charges and discounts to not include %

Copy link
Contributor

@apardods apardods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank your very much for this! Looking great!

@forwardever forwardever mentioned this pull request Dec 5, 2024
@urakozz
Copy link
Contributor

urakozz commented Dec 15, 2024

That's cool, we might also need it soon. I think it would be nice to cut a new release gobl.cii after this get merged, what do you guys think?

@MarlinKuhn
Copy link
Author

Sounds good, im currently using my fork as a replacement and fixing every bug i find. In order to save you some time to review everything new I change, I would recommend merging it sooner than later.

@urakozz
Copy link
Contributor

urakozz commented Dec 19, 2024

@MarlinKuhn we do the same waiting for the release 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants