Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Editor v2 #79

Merged
merged 51 commits into from
Jan 24, 2024
Merged

Visual Editor v2 #79

merged 51 commits into from
Jan 24, 2024

Conversation

beliolfa
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for gobl-build ready!

Name Link
🔨 Latest commit 03e788d
🔍 Latest deploy log https://app.netlify.com/sites/gobl-build/deploys/65b1348a0ffb1300075beac7
😎 Deploy Preview https://deploy-preview-79--gobl-build.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@beliolfa beliolfa marked this pull request as draft November 22, 2023 15:38
@beliolfa beliolfa changed the title WIP: Visual Editor v2 Visual Editor v2 Dec 22, 2023
@samlown
Copy link
Contributor

samlown commented Jan 22, 2024

Looking awesome! A few observations to fix before merge:

  • PDF Preview and download buttons should not be available until the document has been successfully built.
  • Corrective invoice form doesn't appear to be using the visual editor... its not possible for example to add multiple "changes" when correcting a Spanish invoice. Should also fill complete width of modal.
  • If easy to do, the Header should also use a mini-embedded-visual-editor. It is possible to edit the headers, and might be useful.
  • Wrap the contents of the "signatures" modal instead of a single line.

@beliolfa beliolfa mentioned this pull request Jan 23, 2024
@samlown samlown marked this pull request as ready for review January 24, 2024 16:06
Copy link
Contributor

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@samlown samlown merged commit 73ec25a into main Jan 24, 2024
6 checks passed
@samlown samlown deleted the builder_v2 branch January 24, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants