-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: web authentication #335
base: main
Are you sure you want to change the base?
Conversation
Hello, thank you all for the implementation. Is |
Hey @miso-belica 👋 ! Apologies, I was confused on which repo I was working in at the moment. Most of my invertase work is in react-native-firebase which does generate a patch-package set since it is a monorepo and there's no other way for users to test things pre-release. This repository is a regular repo so has no such problem, you should be able to just use the git commit hash as you mention and I think that will be sufficient Curious to know how it works! |
I am eagerly waiting for this ! |
@hyochan please test it using the commit hash as mentioned above and let us know how it goes. I'm waiting to hear some reports on how my rebase worked, as I commented above.
|
I am sorry guys. My prios changed and I was busy with other work. Now, I have a winter vacation but I want to return to this next year for sure 🙂 |
This would break web build due to missing Also it requires to add additional logic for web login which is sad ;( |
This is the result of rebasing PR #166 from @Romick2005 - it was such a large change and I performed no testing it did not feel respectful to push back to that branch as Romick2005 may be depending on it and I can't vouch for the quality of this rebase
In all other ways, refer to that PR though - only changes here are that I attempted to resolve conflicts, and I bumped the react-native-webview and uuid dependencies that the PR added to their current versions and ran
yarn
to update lock files accordinglyThe way to move this forward is for someone to either pull this PR locally and test it, or to use the test patches that this PR should generate (check the Summary page of the Details link for the patch generate CI job below...) and make sure it works.
All contributions welcome