Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): Remove all gms usages and use guava instead #510

Merged
merged 24 commits into from
Oct 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
ff86a1f
feat(android): Remove all gms usages and use guava instead
meypod Sep 4, 2022
6d322f3
chore: add docs for added utility classes
meypod Sep 5, 2022
0b6ef8a
chore: annotate Callbackable.call parameters
meypod Sep 5, 2022
4d041f5
fix: remove gms from rn package build.gradle
meypod Sep 5, 2022
24e6048
fix(NotificationManager): cancelAllNotifications
meypod Oct 3, 2022
e22cb36
fix: null pointer exception in NotifeeAlarmManager
meypod Oct 3, 2022
17e4359
fix: align cancellAllNotifications with pr 352
meypod Oct 5, 2022
727aa10
fix: doScheduledWork success condition
meypod Oct 5, 2022
c3d32e0
Merge pull request #1 from meypod/main
meypod Jan 2, 2023
3f162fc
Merge branch 'main' into migrate_to_guava
meypod Jan 4, 2023
2017311
Merge branch 'main' into migrate_to_guava
meypod Jan 23, 2023
bb3e24c
fix: return of workContinuation in doScheduledWork
meypod Jan 31, 2023
098d704
Merge branch 'main' into migrate_to_guava
meypod Feb 20, 2023
870d16c
Merge branch 'main' into migrate_to_guava
meypod Mar 20, 2023
af6977f
Merge branch 'main' into migrate_to_guava
meypod Apr 17, 2023
ab4a3aa
fix: remove gms from tests as well
meypod Apr 17, 2023
36713fb
Merge branch 'main' into migrate_to_guava
meypod Aug 8, 2024
df33bfc
Merge remote-tracking branch 'origin/main' into migrate_to_guava
mikehardy Oct 1, 2024
36e606d
test(android): note that google-services plugin still needed for RNFB…
mikehardy Oct 1, 2024
46f4b12
style(lint, java): run code through updated google-java-format
mikehardy Oct 1, 2024
b3da878
refactor(android): move main executor service to Notifee / reformat
mikehardy Oct 3, 2024
658dcbf
Merge remote-tracking branch 'origin/main' into migrate_to_guava
mikehardy Oct 3, 2024
76531ab
Merge remote-tracking branch 'origin/main' into migrate_to_guava
mikehardy Oct 5, 2024
a2a4f81
test(ci, ios): simplify simulator / app interaction
mikehardy Oct 5, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 3 additions & 64 deletions .github/workflows/tests_e2e_ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:

- name: Start Simulator
# The first time you try to `yarn run:ios` after xcode-select, it fails, so get it out of the way...
# ...also we need to directly grant notification permission
continue-on-error: true
run: xcrun simctl boot "iPhone 16"

Expand Down Expand Up @@ -123,68 +124,6 @@ jobs:
key: ${{ runner.os }}-v2 # makes a unique key w/related restore key internally
max-size: 400M

- name: Build App, Boot Simulator, Run App
id: run1
timeout-minutes: 30
continue-on-error: true
run: |
export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:/opt/homebrew/bin:$PATH"
export CCACHE_SLOPPINESS=clang_index_store,file_stat_matches,include_file_ctime,include_file_mtime,ivfsoverlay,pch_defines,modules,system_headers,time_macros
export CCACHE_FILECLONE=true
export CCACHE_DEPEND=true
export CCACHE_INODECACHE=true
ccache -s
export SKIP_BUNDLING=1
export RCT_NO_LAUNCH_PACKAGER=1
yarn run:ios
ccache -s
shell: bash

- name: Build App, Boot Simulator, Run App Retry 1
id: run2
timeout-minutes: 30
if: steps.run1.outcome=='failure'
continue-on-error: true
run: |
export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:/opt/homebrew/bin:$PATH"
export CCACHE_SLOPPINESS=clang_index_store,file_stat_matches,include_file_ctime,include_file_mtime,ivfsoverlay,pch_defines,modules,system_headers,time_macros
export CCACHE_FILECLONE=true
export CCACHE_DEPEND=true
export CCACHE_INODECACHE=true
ccache -s
export SKIP_BUNDLING=1
export RCT_NO_LAUNCH_PACKAGER=1
yarn run:ios
ccache -s
shell: bash

- name: Build App, Boot Simulator, Run App Retry 2
id: run3
timeout-minutes: 30
if: steps.run2.outcome=='failure'
continue-on-error: true
run: |
export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:/opt/homebrew/bin:$PATH"
export CCACHE_SLOPPINESS=clang_index_store,file_stat_matches,include_file_ctime,include_file_mtime,ivfsoverlay,pch_defines,modules,system_headers,time_macros
export CCACHE_FILECLONE=true
export CCACHE_DEPEND=true
export CCACHE_INODECACHE=true
ccache -s
export SKIP_BUNDLING=1
export RCT_NO_LAUNCH_PACKAGER=1
yarn run:ios
ccache -s
shell: bash

- name: Simulator Status
if: always()
run: |
if ${{ steps.run1.outcome=='success' || steps.run2.outcome=='success' || steps.run3.outcome=='success' }}; then
echo "Simulator Started"
else
exit 1
fi

- name: Grant Notification Permission
run: applesimutils --booted --setPermissions notifications=YES --bundle com.notifee.testing

Expand All @@ -197,9 +136,9 @@ jobs:
run: nohup sh -c "xcrun simctl spawn booted log stream --level debug --style compact > simulator.log 2>&1 &"

- name: E2E Test
timeout-minutes: 12
timeout-minutes: 30
run: |
export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:/opt/homebrew/bin:$PATH"
export PATH="/opt/homebrew/opt/ccache/libexec:$PATH"
export CCACHE_SLOPPINESS=clang_index_store,file_stat_matches,include_file_ctime,include_file_mtime,ivfsoverlay,pch_defines,modules,system_headers,time_macros
export CCACHE_FILECLONE=true
export CCACHE_DEPEND=true
Expand Down
4 changes: 3 additions & 1 deletion android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,12 @@ dependencies {

api 'androidx.annotation:annotation:1.3.0' // https://developer.android.com/jetpack/androidx/releases/annotation
api 'androidx.concurrent:concurrent-futures:1.1.0' // https://developer.android.com/jetpack/androidx/releases/concurrent
api 'com.google.android.gms:play-services-tasks:18.0.1' // https://developers.google.com/android/guides/releases
api 'androidx.work:work-runtime:2.8.0' // https://developer.android.com/jetpack/androidx/releases/work
api 'com.facebook.fresco:fresco:2.6.0' // https://github.com/facebook/fresco/releases

implementation("com.google.guava:guava:31.1-android") // https://github.com/google/guava
implementation 'androidx.core:core:1.6.0'

def room_version = '2.5.0' // https://developer.android.com/jetpack/androidx/releases/room
implementation "androidx.room:room-runtime:$room_version"
annotationProcessor "androidx.room:room-compiler:$room_version"
Expand Down
Loading
Loading