fix(android): fix headless crash with null ReactContext #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
very tricky to make sure react-native is initialized during headlessJS startup so you don't beat it in the race to asking for a ReactContext before it exists - startup is event-driven so you have to attach listeners - startup has to run on main thread so you have to post runnables - multiple tasks may come in while starting up, you must queue / drain - startup objects / methods differ across react-native new / old arch get all that right, and you'll have a valid ReactContext, without dropping any tasks that needed it before react-native was initialized
mikehardy
added
the
pending-merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1168 +/- ##
=======================================
Coverage 77.08% 77.08%
=======================================
Files 32 32
Lines 1727 1727
Branches 556 556
=======================================
Hits 1331 1331
Misses 395 395
Partials 1 1 |
mikehardy
removed
the
pending-merge
otherwise react-native complains a lot in the log
now there is a button that will create a trigger notification for +15 secs, allowing time to kill the app. Then a background handler should tell you that you got a notification in the background
this should have been in index.js so it could be registered as a background handler prior to AppRegistry registration of the app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
very tricky to make sure react-native is initialized during headlessJS startup so you don't beat it in the race to asking for a ReactContext before it exists
get all that right, and you'll have a valid ReactContext, without dropping any tasks that needed it before react-native was initialized
Previously, we were attempting to use a null ReactContext, resulting in errors from upstream headless services complaining about the context already being destroyed
Fixes #266