fix(android): preserve new-arch classnames used in backwards-compat logic #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogic We use dynamic class-loading via reflection to determine if we are in new architecture mode or not and load the ReactContext If we don't correctly preserve those names in minimization, we will crash in a new architecture context on release builds as the class names will have moved during the minimization
mikehardy
added
the
pending-merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1149 +/- ##
=======================================
Coverage 77.08% 77.08%
=======================================
Files 32 32
Lines 1727 1727
Branches 556 579 +23
=======================================
Hits 1331 1331
Misses 395 395
Partials 1 1 |
mikehardy
removed
the
pending-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use dynamic class-loading via reflection to determine if we are in new architecture mode or not and load the ReactContext
If we don't correctly preserve those names in minimization, we will crash in a new architecture context on release builds as the class names will have moved during the minimization