fix(ios): use new badge APIs to correctly clear badge on iOS18+ #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should eliminate timeout flakiness
on iOS16+ etc there are new badging APIs and to correctly set icon to zero on these devices you cannot use the old-api + set to -1 trick it apparently still leaves the notification center notifications intact though, which is nice
mikehardy
added
the
pending-merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1111 +/- ##
=======================================
Coverage 77.08% 77.08%
=======================================
Files 32 32
Lines 1727 1727
Branches 579 579
=======================================
Hits 1331 1331
+ Misses 395 343 -52
- Partials 1 53 +52 |
mikehardy
force-pushed
the
misc-cleanups
branch
from
19833f2 to
fd24de3
Compare
without this no caching was happening
mikehardy
removed
the
pending-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old workaround of using -1 on the application object no longer works
If iOS16+ use the new setBadge API and a real badge count of 0 and things appear to work
Also includes a series of commits that clean up lint errors all over, and fix up CI flakes
Peeled off from #510 as they were not related and that one will squash merge