Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Remove USE_FULL_SCREEN_INTENT as the default permission #1054

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

exzos28
Copy link
Contributor

@exzos28 exzos28 commented Jun 24, 2024

Starting with Android 14 USE_FULL_SCREEN_INTENT is no longer allowed for most apps. It could be granted only to apps that provide calling and alarm functionalities.
A good way to solve this is to remove USE_FULL_SCREEN_INTENT by default and add a description for NotificationFullScreenAction that it needs USE_FULL_SCREEN_INTENT.

Please check if the docs show correctly because I've not found the way to run typedoc for that repo.

FIxes

@CLAassistant
Copy link

CLAassistant commented Jun 24, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Jul 22, 2024
@exzos28
Copy link
Contributor Author

exzos28 commented Jul 22, 2024

🏓

@github-actions github-actions bot removed the Stale label Jul 22, 2024
@SeifBoukerdenna
Copy link

Bump!

@amjadbouhouch
Copy link

+1

@ravindraguptacapgemini
Copy link

When we are expecting to get this PR merged for a new version of the library

@sofyan-rs
Copy link

+1

@kvark85
Copy link

kvark85 commented Sep 4, 2024

The issue is still relevant

…manifest for Android 14 compat (invertase#1027)

BREAKING CHANGE: Android 14 no longer allows this by default so no longer include by default. Manually add it if you need it.
@mikehardy mikehardy force-pushed the delete_USE_FULL_SCREEN_INTENT branch from 93aceba to 26c8071 Compare September 11, 2024 14:34
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.29%. Comparing base (134e00a) to head (26c8071).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1054   +/-   ##
=======================================
  Coverage   77.29%   77.29%           
=======================================
  Files          32       32           
  Lines        1699     1699           
  Branches      550      571   +21     
=======================================
  Hits         1313     1313           
+ Misses        385      336   -49     
- Partials        1       50   +49     

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! This looks correct for the new Android 14 permissions, thank you

I made these changes in order to get the change in cleanly:

  • rebased to current main
  • removed the typedoc generation (we'll do this on docs publish whenever docs publish works again...or I will do it manually, but the files are generated either way so just having the source change here is enough)
  • altered the commit message to indicate it is a breaking change

All of those are little technicalities though, the fundamental thought is sound and this will merge as soon as CI is happy. Thanks again

@mikehardy
Copy link
Collaborator

Expo users that still need this permission, you will now need to manually configure it:

https://docs.expo.dev/guides/permissions/#android

{
  "android": {
    "permissions": ["android.permission.USE_FULL_SCREEN_INTENT"]
  }
}

@mikehardy mikehardy added the pending-merge Waiting on CI or question responses to merge, but otherwise ready label Sep 11, 2024
@mikehardy mikehardy merged commit 5031a09 into invertase:main Sep 11, 2024
15 checks passed
mikehardy added a commit that referenced this pull request Sep 11, 2024
mikehardy added a commit that referenced this pull request Sep 11, 2024
@mikehardy mikehardy removed the pending-merge Waiting on CI or question responses to merge, but otherwise ready label Sep 11, 2024
@mikehardy
Copy link
Collaborator

released! https://github.com/invertase/notifee/blob/main/docs-react-native/react-native/docs/release-notes.md#900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Declaration USE_FULL_SCREEN_INTENT permission How to remove USE_FULL_SCREEN_INTENT?
8 participants