-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): Remove USE_FULL_SCREEN_INTENT as the default permission #1054
fix(android): Remove USE_FULL_SCREEN_INTENT as the default permission #1054
Conversation
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
🏓 |
Bump! |
+1 |
When we are expecting to get this PR merged for a new version of the library |
+1 |
The issue is still relevant |
…manifest for Android 14 compat (invertase#1027) BREAKING CHANGE: Android 14 no longer allows this by default so no longer include by default. Manually add it if you need it.
93aceba
to
26c8071
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1054 +/- ##
=======================================
Coverage 77.29% 77.29%
=======================================
Files 32 32
Lines 1699 1699
Branches 550 571 +21
=======================================
Hits 1313 1313
+ Misses 385 336 -49
- Partials 1 50 +49 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! This looks correct for the new Android 14 permissions, thank you
I made these changes in order to get the change in cleanly:
- rebased to current main
- removed the typedoc generation (we'll do this on docs publish whenever docs publish works again...or I will do it manually, but the files are generated either way so just having the source change here is enough)
- altered the commit message to indicate it is a breaking change
All of those are little technicalities though, the fundamental thought is sound and this will merge as soon as CI is happy. Thanks again
Expo users that still need this permission, you will now need to manually configure it: https://docs.expo.dev/guides/permissions/#android {
"android": {
"permissions": ["android.permission.USE_FULL_SCREEN_INTENT"]
}
} |
… if needed doc change related to #1054
… if needed doc change related to #1054
Starting with Android 14 USE_FULL_SCREEN_INTENT is no longer allowed for most apps. It could be granted only to apps that provide calling and alarm functionalities.
A good way to solve this is to remove USE_FULL_SCREEN_INTENT by default and add a description for NotificationFullScreenAction that it needs
USE_FULL_SCREEN_INTENT
.Please check if the docs show correctly because I've not found the way to run typedoc for that repo.
FIxes